Sudden game slowdown

[ZemZamano]

Describe the bug

The game was running smoothly until at one point, it slowed to a crawl. the usual suspects like lots of zombies or items are ruled out since its a wilderness playtrough. i'mtalking about slowdown while sleeping or crafting

Steps To Reproduce

i attached my save file. just craft a recipe that needs like an hour or so to [complete.]

Versions and configuration

• OS: Win 10
• Game Version: 0.E-6259-g34af6ba
• Graphics version: Tiles. tried undead people and ultica, same result
• Ingame language: English
• Mods loaded: [e.g.dda, boats, hacktheplanet, StatsThroughSkills]

edit:forgot the save file here's the link: https://gofile.io/d/2SO0tQ

[ZemZamano]

in addition things that seem weird and may be connected: my minimap is covered in a strange grid. also continuing on my chitinous armguards does not give me proficiency even though i have all requirements edit: minimap problem was not related and proficiency gain seems normal again

edit: also i just had this error message that might be related:
DEBUG : can't set ammo null in smoking rack as it is not an ammo

FUNCTION : item& item::ammo_set(const itype_id&, int)
FILE : src/item.cpp
LINE : 600

[anothersimulacrum]

2/3rds of the time spent in game::do_turn (which is by far where the most time is spent), is in game::overmap_npc_move. Reminds me of #30288
Specifically, in this bit:

Cataclysm-DDA/src/overmapbuffer.cpp

Lines 734 to 783 in 7f98932

	[&]( const pf::node<point_rel_omt> &cur, const pf::node<point_rel_omt> * ) {
	const tripoint_abs_omt convert_result = base + tripoint_rel_omt( cur.pos, 0 );
	if( ptype.only_known_by_player && !seen( convert_result ) ) {
	return pf::rejected;
	}
	int res = 0;
	const oter_id oter = get_ter_at( cur.pos );
	int travel_cost = static_cast<int>( oter->get_travel_cost() );
	if( ptype.avoid_danger && is_marked_dangerous( convert_result ) ) {
	return pf::rejected;
	}
	if( ptype.only_road && ( !is_ot_match( "road", oter, ot_match_type::type ) &&
	!is_ot_match( "bridge", oter, ot_match_type::type ) &&
	!is_ot_match( "road_nesw_manhole", oter, ot_match_type::type ) ) ) {
	return pf::rejected;
	}
	if( ptype.only_water && !is_river_or_lake( oter ) ) {
	return pf::rejected;
	}
	if( ptype.only_air && ( !is_ot_match( "open_air", oter, ot_match_type::type ) ) ) {
	return pf::rejected;
	}
	if( is_ot_match( "empty_rock", oter, ot_match_type::type ) ) {
	return pf::rejected;
	} else if( is_ot_match( "open_air", oter, ot_match_type::type ) ) {
	if( ptype.only_air ) {
	travel_cost += 1;
	} else {
	return pf::rejected;
	}
	} else if( is_ot_match( "forest", oter, ot_match_type::type ) ) {
	travel_cost = 10;
	} else if( is_ot_match( "forest_water", oter, ot_match_type::type ) ) {
	travel_cost = 15;
	} else if( is_ot_match( "road", oter, ot_match_type::type ) ||
	is_ot_match( "bridge", oter, ot_match_type::type ) ||
	is_ot_match( "road_nesw_manhole", oter, ot_match_type::type ) ) {
	travel_cost = 1;
	} else if( is_river_or_lake( oter ) ) {
	if( ptype.amphibious || ptype.only_water ) {
	travel_cost = 1;
	} else {
	return pf::rejected;
	}
	}
	res += travel_cost;
	res += manhattan_dist( finish, cur.pos );
	return res;
	};

(See how the next most expensive this is about 1/7th of this, and is the game checking for input(actually redrawing the UI).)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[stale]

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

[Aivean]

@ZemZamano , if this is still valid, please re-attach the save file. You can drop files directly into the github comment window.

[ZemZamano]

@Aivean
Here is a the save file in question. just start a craft that requires some time. In this particular world there is nothing around that could tank the performance other then the NPCs

slowdown.zip

[Aivean]

Thank you.

I can reproduce it. I wouldn't call simulation speed here excessively slow, but yes, as anothersimulacrum above pointed out, game::overmap_npc_move() is taking up 81% of simulation time, which is not ideal.

I'll see what I can do.

[Aivean]

On my machine: