Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various regarding item: "rigid_plastic_sheet" #39617

Closed
SgtMustang opened this issue Apr 16, 2020 · 2 comments
Closed

Various regarding item: "rigid_plastic_sheet" #39617

SgtMustang opened this issue Apr 16, 2020 · 2 comments
Labels
Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid.

Comments

@SgtMustang
Copy link

SgtMustang commented Apr 16, 2020

Game Version: 0.E-732-gd0f0a96 [64-bit]
OS: Windows 10.0 1909
Tiles or curses: Tiles

See commit #38475, which added rigid_plastic_sheet to data\json\items\resources\plastic.json.

Issues

  1. This item has name ambiguity with plastic_sheet; they are both called "plastic sheet" in game.

  2. It appears the plastic windows implemented by the commit require rigid_plastic_sheet to construct, but are deconstructed into plastic_sheet.

Other Information

plastic_sheet is the item used in the ANBC,AEP and tarp shelter recipes. This commit also adds a recipe for constructing rigid_plastic_sheet, using 200 plastic chunks.

Expectation

Name rigid_plastic_sheet accordingly in game to eliminate the ambiguity, or merge with the existing *plastic_sheet.

@stale
Copy link

stale bot commented May 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label May 17, 2020
@stale
Copy link

stale bot commented Jun 16, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

2 participants