Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetic ordering of weapons in martial arts description #39529

Closed
GGgatherer opened this issue Apr 13, 2020 · 2 comments · Fixed by #39815
Closed

Alphabetic ordering of weapons in martial arts description #39529

GGgatherer opened this issue Apr 13, 2020 · 2 comments · Fixed by #39815
Labels
Info / User Interface Game - player communication, menus, etc. Melee Melee weapons, tactics, techniques, reach attack Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA <Suggestion / Discussion> Talk it out before implementing

Comments

@GGgatherer
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It is more QoL request than problem fix. Some martial arts have many many weapons they work with, especially if you add mods to the picture. Kinda hard to find if a weapon works with MA or not when the list is unordered.

Describe the solution you'd like

Alphabetic ordering of compatible weapons list. Surely it's better than no ordering at all.

Describe alternatives you've considered

Continue searching for needles in a haystack each time you want to check weapon/MA compatibility.

@Night-Pryanik Night-Pryanik added <Suggestion / Discussion> Talk it out before implementing Info / User Interface Game - player communication, menus, etc. Melee Melee weapons, tactics, techniques, reach attack Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA labels Apr 13, 2020
@Pupsi-Mupsi
Copy link
Contributor

I know that this is not a solution. More kind of a workaround.

Consider searching for the right weapon - use the crafting menu like this:
grafik

Also:

Recipes and items indicate the martial art style with which they could be used.
Take a look at: #39653

@GGgatherer
Copy link
Contributor Author

I agree it is helpful but it applies to craftable weapons only.
I know you can look at the weapon to know which MAs it can be used with but there are not so many MAs to populate those lists, so even if they are unsorted(are they? I honestly never noticed if they are) it isn't much of a problem to look through them. It's the other way around (weapons compatible with MA) that's irritating to use.

Also, I checked martialarts.cpp and it doesn't seem to relate on any specific ordering of "weapons" array which is used to populate used weapons list (would be strange if it did when there's no ordering anyway).
So adding sort command to the end of martialart::load should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Melee Melee weapons, tactics, techniques, reach attack Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
3 participants