Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle disappear when moving from another mapchunk and re-appear when in vehicle mapchunk #38292

Open
drago888 opened this issue Feb 24, 2020 · 7 comments
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions

Comments

@drago888
Copy link

Describe the bug

Vehicle disappear when entering a new mapchunk but reappear when moving back into vehicle mapchunk

A gigantic vehicle working as Power grid for my base will disappear when I exit the vehicle mapchunk that the vehicle is on. It will reappear with the vehicle parts in the other mapchunk when I enter the vehicle mapchunk.

Version: 0.D Stable

Steps To Reproduce

  1. Create a vehicle near the border of 2 mapchunks
  2. Extend the vehicle such that it extends into the other mapchunk
  3. Move towards the other mapchunk and observe if vehicle disappear
  4. If disappear, walk towards the vehicle mapchunk to see it appearing

Expected behavior

The vehicle shall exist in both mapchunk if there are any cross mapchunk.
Thus there shall not be disappearing cases.

Screenshots

Still in mapchunk -
![Uploading 20200224-screenshot.png…]

One step out of mapchunk -
20200224-screenshot_1

Versions and configuration

  • OS: [Ubuntu 18.04]
  • Game Version: [cataclysmdda-0.D-8574]
  • Graphics version: [Tiles]
  • Ingame language: [English]
  • Mods loaded: [dda, filthy clothing, bens GF Recipes,Craftable Gun pack, extended realistic guns, makeshift items mod, medieval and historic content, more survival tools, modular turrets, salvaged robots, alternative map keys, mutant npc, more location, fuji's more building, boats, vehicle additions packs, tanks and other vehicle ]

Additional context

@drago888
Copy link
Author

Screenshots

Still in mapchunk -

20200224-screenshot

@Funguss
Copy link
Contributor

Funguss commented Feb 24, 2020

I do believe this has been fixed. I'll try loading your save up.

Edit: Err, I won't do that after all as you've not uploaded the save! In that case would you mind downloading the latest experimental and testing it on there? You can use the CDDA game launcher to download and update it conveniently.

Most bugs in 0.D should be fixed (or at least reported) by now. When making a report there's a button that shows issues that are similar based on your title. A search of closed and open issues is a good idea regardless, but especially for 0.D bugs.

Edit 2: Been hunting for the PR I'm pretty sure fixes this but I can't find it. Quitting for now! If anybody else can find it, great.

@drago888
Copy link
Author

Hihi Funguss,

Will try downloading the experimental to test probably tomorrow.

Thanks. If still not fixed, will upload my save file.

@drago888
Copy link
Author

Hi Funguss,

Tried with experimental 0.D-12517-g92b0b2c and problem still persist.

Attached is the save file. Even tried removing offending vehicle part and inserting but still same issue.

Thanks
save.zip

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions labels Feb 25, 2020
@Funguss
Copy link
Contributor

Funguss commented Feb 25, 2020

Ok, wow, yeah it looks like your vehicle is getting unloaded, though moving one square east doesn't take you into a new chunk. IIRC vehicles unload when their point of origin (the first tile constructed) leave the simulated area. I could have sworn this issue was fixed. I was also certain that jumper cables prevented vehicles unloading until their connected vehicles were unloaded, too. Sorry for getting your hopes up!

It may be that the vehicle is invisible, or that it's still loaded but isn't placed on the map. I'm not entirely sure how to go about testing this.

@Qrox
Copy link
Contributor

Qrox commented Feb 25, 2020

Just a wild guess, but it could also be an issue with the submap vehicle cache.

@BevapDin
Copy link
Contributor

This is a limitation of the game engine. Each vehicle is stored within a map chunk and if that map chunk is not part of the reality bubble, the vehicle it contains are not part of the reality bubble either.

Fixing this would need to load all (or at least very many) surrounding map chunks just to load the vehicles that are also part of the reality bubble. And vehicles have no size limit, so we would have to expect a vehicle stored a dozen map chunks away can still have parts in the reality bubble.

You can make multiple vehicles and connect them via jumper cables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

No branches or pull requests

5 participants