Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapgen sometimes generates completely empty towns #37856

Closed
l29ah opened this issue Feb 9, 2020 · 7 comments · Fixed by #51769
Closed

Mapgen sometimes generates completely empty towns #37856

l29ah opened this issue Feb 9, 2020 · 7 comments · Fixed by #51769
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display

Comments

@l29ah
Copy link
Contributor

l29ah commented Feb 9, 2020

Made of a few roads.

Expected behavior

Either no town or a populated town.

Screenshots

Versions and configuration

  • OS: Linux
    • OS Version:
  • Game Version: 0.D-12025-g40c494c222-dirty [64-bit]
  • Graphics Version: Curses
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Alternative Map Key [alt_map_key],
    No Rail Stations [No_Rail_Stations]
    ]

Additional context

Add any other context about the problem here.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Feb 9, 2020
@TechyBen
Copy link
Contributor

Hey, could always make it a feature. Urban planning and all that. A sign stating "Real Estate for Sale" would be nice though if the worldgen can detect it as empty. :P

@Funguss
Copy link
Contributor

Funguss commented Feb 12, 2020

That's actually an accurate representation of Gouldsboro, Maine. It's kinda scary.

@Night-Pryanik
Copy link
Contributor

@l29ah is this issue still valid?

@l29ah
Copy link
Contributor Author

l29ah commented May 4, 2021

Yes, i just got one:
screenshot-empty-town

@Night-Pryanik
Copy link
Contributor

@l29ah What's your setting for size of cities?

@l29ah
Copy link
Contributor Author

l29ah commented Sep 20, 2021

4

@Night-Pryanik
Copy link
Contributor

That explains it. According to the code, with size of cities set to 4 or less, there is a fairly high chance to spawn such 1-tile "city".
We might need to increase the minimum size of cities to 2 to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants