Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of information when debugging survivor stories #37750

Closed
la-magra opened this issue Feb 6, 2020 · 2 comments
Closed

Lack of information when debugging survivor stories #37750

la-magra opened this issue Feb 6, 2020 · 2 comments
Labels
Info / User Interface Game - player communication, menus, etc. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies NPC / Factions NPCs, AI, Speech, Factions, Ownership

Comments

@la-magra
Copy link

la-magra commented Feb 6, 2020

Game version: compiled, master branch (6017c7c)

Operating system: Linux x64 (I use Arch by the way)

Tiles or curses: curses

Mods active: none, only Dark Days ahead

Expected behavior

Debug menu should provide a minimal amount of information in order to ease debugging (trait ids in particular).

Actual behavior

It does not.

Steps to reproduce the behavior

Start game, debug menu, p, p, 1, u, click every survivor story to know which one you want to test.

Code that solves it

--- a/src/wish.cpp
+++ b/src/wish.cpp
@@ -93,6 +93,10 @@ class wish_mutate_callback: public uilist_callback
                        mdata.valid ? _( "Valid" ) : _( "Nonvalid" ) );
             int line2 = 4;

+            line2++;
+            mvwprintz( menu->window, point( startx, line2 ), c_light_gray,
+                       "ID: " + std::string( vTraits[entnum].c_str() ) );
+
             if( !mdata.prereqs.empty() ) {
                 line2++;
                 mvwprintz( menu->window, point( startx, line2 ), c_light_gray, _( "Prereqs:" ) );

If code looks ok/approved I can open a PR, or the diff is free to grab by anyone.

@anothersimulacrum
Copy link
Member

You should just open a PR. Other than the unnecessary increment (just set it to 5 initially), diff looks fine to me (unfamiliar with that code are though).

@ZhilkinSerg
Copy link
Contributor

Yeah, don't need an open issue for debug features - just make a PR with whatever changes necessary.

@ZhilkinSerg ZhilkinSerg added Info / User Interface Game - player communication, menus, etc. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

No branches or pull requests

3 participants