Landmines use old explosives code.

[Brian-Otten]

Describe the bug

Landmines still use old explosion code which makes them not behave as the player might expect
in data/json/traps.json, line 363 and 377
"vehicle_data": { "do_explosion": true, "damage": 1000, "shrapnel": 8, "sound_volume": 10 }

Expected behavior

Game handles landmines like it does the other explosives. example:

"vehicle_data": { "do_explosion": true, "explosion": { "power": 240, "shrapnel": { "casing_mass": 217, "fragment_mass": 0.15 } }

The exact values are less important since i will be reworking landmine components/crafting in the near future, but should be similar to the hand grenade.

Additional context

I tried implementing myself but it doesn't expect the explosion code in that json and i have no idea how to make it work.

[CountAlex]

I believe you should check function trapfunc::landmine() at src/trapfunc.cpp:L605
It clearly uses same explosion() function but uses preset values so I think that landmine probably does not use JSON set values at all.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[stale]

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it