Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike Pit and Glass Pit Blueprint zone does not build over extant shallow pit #37297

Open
CSHague opened this issue Jan 22, 2020 · 8 comments
Open
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling

Comments

@CSHague
Copy link
Contributor

CSHague commented Jan 22, 2020

Describe the bug

Attempting to build a construction of a glass or spike pit over a currently existing shallow pit via the construction zone manager does not allow the construction to complete. NPCs given the task will end with " completed the assigned task" without digging a deep pit to continue the pit construction. With player attempting to build construction plots exits the menu with no response. This only applies with shallow pits when making spike or glass pits as far as I've tested. Building a log wall over an existing shallow pit works fine. If any shallow pit is anywhere in the blueprint zone, the action will fail, even if there are other eligible tiles to be dug.

Steps To Reproduce

  1. Dig a shallow pit with a tool.

  2. Designate a spike pit or glass pit over the shallow pit.
    3a. Attempt to construct plots with zone action menu. Nothing happens.
    3b. Order recruited NPC to do some construction work. Message log declares " has completed assigned task." This is not the case.

Expected behavior

Should dig a deep pit to move on to making a spike or glass pit.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.D-11538-gf27d795 [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Magiclysm [magiclysm],
    Aftershock [aftershock],
    Bens GF recipes [Tolerate_This],
    Garden Pots [growable-pots],
    Medieval and Historic Classes and Shields [Medieval_Stuff],
    More Survival Tools [More_Survival_Tools],
    Makeshift Items Mod [makeshift],
    Modular Turrets [modular_turrets],
    Salvaged Robots [Salvaged_Robots],
    Hydroponics [hydroponics],
    Mutant NPCs [mutant_npcs],
    Beta National Guard Camp [national_guard_camp],
    More Locations [more_locations],
    Fuji's More Buildings [FujiStruct],
    Folding Parts pack [deoxymod],
    Vehicle Additions Pack [blazemod],
    Roadheader and other mining vehicles [Heavy miners],
    Tanks and Other Vehicles [Tanks]
    ]

Additional context

I think the problem might have something to do with Deep Pit being missing as a construction task. While testing, a glass pit will dig to completion over regular terrain. Somewhere the process cannot begin with a shallow pit but must go from dirt to shallow pit construction to deep pit construction but the shallow pit never gets checked as part of the terrain for the next in-progress construction to be placed. However, if the process starts with a shallow pit, it doesn't know where to go because shallow pit to deep pit doesn't exist as a construction but as a vague step between. That's just a guess, however.

@snipercup
Copy link
Contributor

I have the same problem except the npc will not construct a spike pit on a deep pit.

This is the terrain:
image

I can manually construct the spike pit:
image

The zone:
image

The NPC never starts, just completes the task with no action taken:
image

@CSHague
Copy link
Contributor Author

CSHague commented Jan 22, 2020

@snipercup You have the spears for the pit there? I just tested this in my game and I was able to make spike pits from deep pits in a zone.

@snipercup
Copy link
Contributor

Yeah the second screenshot shows the pointy sticks are present. They are on the ground in the camp storage zone. I have not tried using spears. I did not have my player character try to construct the spike pit, I want the npc to do it.

@CSHague
Copy link
Contributor Author

CSHague commented Jan 23, 2020

Yeah, that's what I meant, I had an NPC do the same thing with an already-dug deep pit and wooden spears directly at her feet. When she didn't have spears, there would be a delay where she would walk to pit and then "complete the assigned task" but with my shallow pits, the task end message shows up one turn after closing the npc chat box and they make no attempt to move to the spot. Is this behavior identical in your instance? I see the log showing one second difference so it would appear that way but I just wanna confirm.

@snipercup
Copy link
Contributor

Ah Okay I get it now, you had the spear directly at the feet. I tried that as well
image

He then made the construction:
image

I did notice I could not drop the pointy sticks on the tile because it was full:
image

So I had to move some soil first so I could drop the pointy sticks on that tile. I'm guessing the NPC tried to move the pointy sticks but also ran into the issue of not being able to drop it? Actually, that's not the case, he can work with the pointy sticks one tile away:
image

The tile he is standing on is full (1000L) and the sticks are not moved by the npc. I guess you are right, the sticks have to be close to the construction otherwise the NPC thinks there is no construction material even though the sticks are in the faction camp storage. But then again you could issue a construction order without a faction camp.

I wouldnt consider this a problem if the NPC told me what is going on but we need #37300 for that.

@CSHague
Copy link
Contributor Author

CSHague commented Jan 23, 2020

I think they will fetch anything that's visible for the task. I watched NPCs walk 12 tiles away to get glass from shattered windows for a glass pit

@ghost
Copy link

ghost commented Jan 23, 2020

They will use stuff thats within crafting range already, or go and fetch needed components if they are in a loot zone.

@stale
Copy link

stale bot commented Feb 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Feb 22, 2020
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Feb 22, 2020
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

No branches or pull requests

3 participants