Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migo structure is unmarked on overmap #36511

Closed
ymber opened this issue Dec 28, 2019 · 6 comments · Fixed by #55291
Closed

Migo structure is unmarked on overmap #36511

ymber opened this issue Dec 28, 2019 · 6 comments · Fixed by #55291
Labels
Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display

Comments

@ymber
Copy link
Member

ymber commented Dec 28, 2019

Describe the bug

I ran into 15 migos in an open field that turned out to be from some kind of migo structure that wasn't marked on the overmap.

Steps To Reproduce

Unknown. All other migo structures in this game are visible on the overmap.

Expected behavior

Migo structures are marked on the overmap.

Versions and configuration

@ymber ymber added <Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display (P3 - Medium) Medium (normal) priority labels Dec 28, 2019
@anothersimulacrum
Copy link
Member

This is very likely one of the possible variants of the mx_portal_in map extra.

@ghost
Copy link

ghost commented Dec 28, 2019

That would generate special note on map tho (unless disabled), something might be afoot as on my end I've ran into several unmarked barns and single tile sized patches of forest appearing on map as field after recent pull..

@sztosz
Copy link
Contributor

sztosz commented Dec 28, 2019

Those barns and small forests were added as some flavor to just before X-Mass, it was this PR #35990 I believe. But they are really just to break the monotony of the grass, there is nothing really special with them, and so they are not being mark on the overmap.

@ghost
Copy link

ghost commented Dec 28, 2019

Ahh, I see. I suppose they are at least easier to spot than solitary trees when off-road driving but in turn require larger course corrections, and I'd still prefer to have them marked automatically.

@Night-Pryanik
Copy link
Contributor

This mi-go structure isn't a separate overmap terrain, it's just a bunch of terrains and monsters spawned in the field, so it can't be marked like other locations.

I guess as a possible solution we could create a json-version of the structure and make it spawn on universal basis when the corresponding map extra triggers, but in any case that's definitely not a bug.

@Night-Pryanik Night-Pryanik removed (P3 - Medium) Medium (normal) priority <Bug> This needs to be fixed labels Apr 4, 2021
@ymber
Copy link
Member Author

ymber commented Apr 8, 2021

I think it should be removed as a map extra. The resin structure would be visible from a long distance and it's substantial enough to justify being its own OMT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants