Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing mutation interaction #36126

Closed
Swootch opened this issue Dec 15, 2019 · 1 comment · Fixed by #36292
Closed

Missing mutation interaction #36126

Swootch opened this issue Dec 15, 2019 · 1 comment · Fixed by #36292

Comments

@Swootch
Copy link
Contributor

Swootch commented Dec 15, 2019

Describe the bug

Venomous mutation does not interact with Large Talons mutations when attacking unarmed. It does not apply its poison effect.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Make a player with the Venomous and Large Talons mutations.
  2. Attack an enemy without weapons and deal cut damage.
  3. The attacks don't apply poison.

Expected behavior

Unarmed melee attacks have the advertised chance to apply poison when dealing cutting damage. Unarmed attacks with the Large Talons mutation deal cut damage, which, technically, qualifies them for the Venomous mutation to take effect:

Untitled3

The Large Talons mutation turns the player's unarmed melee attacks into the cutting type, this is an example of me doing that:

Untitled4

Venomous probably doesn't recognize the attacks as viable for its effect because they're not extra attacks like a Beak mutation gives you, which by the way does apply the poison effect.

Version: Latest as of 15th December 2019, tested with no mods.

@Fris0uman
Copy link
Contributor

Yeah so looking at the code only special attack can apply the poison effect. Since special attacks happen in the same turn as normal attack we can either make it so one of those poison the enemy if it deals cut/stab damage or make it OP and have both of them deal poison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants