Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game warns of zombies being aimed at #36088

Closed
glenmack opened this issue Dec 14, 2019 · 7 comments
Closed

Game warns of zombies being aimed at #36088

glenmack opened this issue Dec 14, 2019 · 7 comments
Labels
Info / User Interface Game - player communication, menus, etc. Mechanics: Character / Player Character / Player mechanics stale Closed for lack of activity, but still valid.

Comments

@glenmack
Copy link
Contributor

Expected behavior

Not interrupt aiming at a particular zombie to tell you it is there.

Actual behavior

Only one zombie in sight, already aiming at it, steadying aim is interrupted to tell you X type zombie approaching.

Steps to reproduce the behavior

Aim at approaching zombie with safe mode on.

@Night-Pryanik Night-Pryanik added Mechanics: Character / Player Character / Player mechanics Info / User Interface Game - player communication, menus, etc. labels Dec 14, 2019
@Ramza13
Copy link
Contributor

Ramza13 commented Dec 18, 2019

Pretty sure #35983 will fix this. EDIT: It doesn't as pointed out.

@glenmack
Copy link
Contributor Author

Pretty sure #35983 will fix this.

From what I've read, no it doesn't. Your fix ignores things based on distance and z-level. Not on whether it is being aimed at or not. I will still want to be informed of other approaching monsters just not the particular one I'm aiming at because I already know it is there.

@Ramza13
Copy link
Contributor

Ramza13 commented Dec 18, 2019

Pretty sure #35983 will fix this.

From what I've read, no it doesn't. Your fix ignores things based on distance and z-level. Not on whether it is being aimed at or not. I will still want to be informed of other approaching monsters just not the particular one I'm aiming at because I already know it is there.

Good point.

@JeanLucVanDamme
Copy link

JeanLucVanDamme commented Jan 14, 2020

I will still want to be informed of other approaching monsters just not the particular one I'm aiming at because I already know it is there.

Agreed. This is incredibly irritating when playing as ranged characters. Yes, I know it's been sighted, that's why I'm aiming.

Sometimes it's even the only creature in sight, and you're prompted several times at different distances. Sometimes the creature is super low-powered and poses no threat at any distance.

@Ramza13
Copy link
Contributor

Ramza13 commented Jan 15, 2020

So I have been looking into fixing this and have some questions.

First while I remember this happening to me I'm having trouble reproducing it for testing, does anyone have steps/settings to force it to occur?

Second I noticed in the code that at present the warning about a monster being dangerously close will not happen while you are aiming regardless of target. It would be quite easy to move this check from where it is to happen anytime you spot a monster.

This isn't quite the ask but would be very easy and is already the behavior of the dangerously close warning which is supposed to be the last line of defense so it would standardize the behavior.

Would this be considered an acceptable fix?

@stale
Copy link

stale bot commented Feb 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Feb 15, 2020
@stale
Copy link

stale bot commented Mar 16, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Mechanics: Character / Player Character / Player mechanics stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

4 participants