Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varying fouling levels and firearm state during character creation #36004

Closed
CountAlex opened this issue Dec 10, 2019 · 2 comments · Fixed by #37126
Closed

Varying fouling levels and firearm state during character creation #36004

CountAlex opened this issue Dec 10, 2019 · 2 comments · Fixed by #37126
Labels
<Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Milestone

Comments

@CountAlex
Copy link
Contributor

CountAlex commented Dec 10, 2019

Describe the bug

Professions with a firearm in equip allow different state/fouling for a gun with multiple choosing of a profession.

Steps To Reproduce

  1. Initiate character creation
  2. Find one with a firearm
  3. Scroll back and forth watching fouling level and state of a firearm (faulty/not faulty)

Expected behavior

Predefined level of fouling/functionality of a firearm whether global or per profession.

Screenshots

1
2
3

Versions and configuration

OS: Win 7x64
Game Version: 0.D-10040-ge8bfb5e
Graphics version: Tiles
Mods loaded:Disable NPC needs

Additional context

N/A

@kevingranade
Copy link
Member

Pinning this to 0 fouling would be fine, as would making it configurable in the profession spawn list.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Dec 11, 2019
@anothersimulacrum
Copy link
Member

Note that after #36341 this is harder to see, but fouling is still being varied when guns are spawned here.
It would be possible to fix this in JSON by specifying when guns are spawned that they have 0 fouling in the itemgroup, but that's a bit fragile - some solution capping it to 0 unless otherwise specified would be better, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants