Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farming plot zone - QoL improvement features #24826

Closed
4 of 9 tasks
Robik81 opened this issue Aug 14, 2018 · 6 comments
Closed
4 of 9 tasks

Farming plot zone - QoL improvement features #24826

Robik81 opened this issue Aug 14, 2018 · 6 comments
Labels
<Enhancement / Feature> New features, or enhancements on existing <Suggestion / Discussion> Talk it out before implementing

Comments

@Robik81
Copy link
Contributor

Robik81 commented Aug 14, 2018

Farming plot zone

Aims to improve farming ease of use and to allow for further farming enhancements without making it less user friendly.

Current state of farming

While farming is a great feature, it tends to be key press heavy and this problem seems to be increasing with time, rather than decreasing. In the near future, an Improve crop farming PR #24291 will be introduced and while it greatly enhances farming, some did express worries about excessive tediousness of such system.

I happen to agree that something has to be done to allow for such great improvement without killing all the fun in farming for the user.

Quality of life features to help remedy the issue

  • designate a zone as a farming plot
  • action for tilling of nearby plots
  • implement support for the designating seed for the plot (wheat plot, strawberry plot, etc.)
  • action for planting on nearby plots
  • action for harvesting nearby plots
  • watering plants
  • fertilizing plants
  • removing weeds
  • ?

While I do have designating seed and planting marked as done, these would have to be updated, once #24291 is merged.

To give a better idea, how would such system work, I prepared short 1 minute video with my current implementation in action.

https://youtu.be/H8tBR3GdZLE

@nexusmrsep
Copy link
Contributor

Looks sweet, great design idea.

@Night-Pryanik Night-Pryanik added <Enhancement / Feature> New features, or enhancements on existing <Suggestion / Discussion> Talk it out before implementing labels Aug 14, 2018
@Vasyan2006
Copy link
Contributor

I have planned to do something like thant in the future, but you already done most of the work.
Crop tending can be included relatively simple by separating watering and other actions into functions with plant tripoint as a parameter, and using them for every plant in the plot zone. These functions can be also used for NPC farms. I can do it, but I think it should wait until main farming PR will be merged.

@Robik81
Copy link
Contributor Author

Robik81 commented Aug 14, 2018

In my work on planting, I heavily refactored iexamine::dirtmound to pieces, so I could call the same code. If your watering etc. will be call from the outside ready, it will make the things easier for me.

But yeah, no need to do it now. Let's wait until your PR is merged.

@Nightquaker
Copy link

Nightquaker commented Aug 31, 2018

Ideally, I really like when such features are optional.
People who don't have much time to spare and want to avoid tedium use the feature like that to get around faster.
And people who do have time to spare and want to simulate the real-life tedium of manual farming (for example), would just not have to use the feature that automates it all.
Since this is related to zones, from what I understand it will be optional, so it's all good in that regard.

@prutschman
Copy link
Contributor

Pull request #27278 contains a candidate implementation of zone activity commands for harvesting and fertilization.

@ghost
Copy link

ghost commented Jan 29, 2020

Closing as this is now addressed by zone farming activities, which now includes harvesting, and fertilizing.
If watering and weeding is required in future, the framework for the zone activities should allow for that fairly easily.

@ghost ghost closed this as completed Jan 29, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

6 participants