Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle_liquid needs to be refactored #24679

Closed
mlangsdorf opened this issue Aug 7, 2018 · 0 comments
Closed

handle_liquid needs to be refactored #24679

mlangsdorf opened this issue Aug 7, 2018 · 0 comments
Assignees
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style

Comments

@mlangsdorf
Copy link
Contributor

As written, handle_liquid does two different things: selects the container for a liquid transfer, and performs the transfer. It would be helpful to split those functions into two different functions: one that
selects the container, the other that performs the transfer. Other code that wanted to transfer liquid
in different ways would be able to call either function, as needed.
handle_liquid would remain as a wrapper that calls the two functions in sequence, so existing code
wouldn't need to change.

I'm going to go write this so I can create a MILKING activity.

@DracoGriffin DracoGriffin added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

No branches or pull requests

2 participants