Draw time increase after #22579

[Dyrewulfe]

Game version: Any after build 7002

Operating system: Windows, Linux, Android

Tiles or curses: Tiles

Mods active: None

Draw time spiked after PR #22579. The effect is mitigated by the performance boost this provided to hardware rendering. It's extremely noticeable in software

Profiling indicates that game::draw_ter(bool) is taking roughly 12 times as long as it previously did.

[Leland]

Pinging @BevapDin

Also, @Graywolfe813 left some notes on the closed #22579, copying here for visibility:

I suspect there's a glitch in here somewhere. Relative hardware performance has improved compared to software(due to not having to constantly bind/unbind textures), but the overall drawing performance has decreased dramatically.

I'm running an Intel integrated, but it wasn't affected by #21317. The issue affects both Windows(OpenGL and Direct3D backends) and Linux builds, as well as my Android devices I've tested on.

Is there a logic error here causing unnecessary drawing, perhaps?

Edit: I'm asking because if there is, I'm not seeing it.

Also, the Android port UI elements are broken by this PR, which should not be the case as they're handled directly. My gut says the screen is being redrawn excessively.

[RedPine91]

Is this the culprit that is making craft times excessively long? Normally, when I install a vehicle part, the process is nearly instant, but now I suffer 3 sec of IRL time for every 5 min game time each installation takes. This has made interacting with vehicles nigh unbearable. EDIT: To clarify, this means a 15 minute seat installation takes IRL 8 seconds.

I parked the vehicle far from zombies, no hordes are on minimap, I have only 1 NPC, and there are only 6 cargo spaces full of loot, so this is the only thing I can think of that could be slowing the game down.