house mapgen occasionally overlaps table and wall

[sparr]

While working on #11631 I found one glitch that I couldn't fix. The generic "house" sometimes spawns a table and some other furniture in a room that's too small for them, so the table intersects a wall.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[narc0tiq]

Would forcing the room to be bigger help?

[sparr]

maybe. the house generation code is the most twisted of any of the dynamic-room functions I've touched yet.

[Leland]

Have never seen this – can anyone confirm that this still happens?

[Leland]

Closing due to lack of reproducibility; feel free to either ping me here to reopen or just create a new issue.

[FulcrumA]

@Leland
Pinging as this thing happened just now to me:

• OS: Win7
• Game Version: 0.D-4931-g7eb2ac0 ((build 9218)
• Graphics version: Tiles
• Mods loaded: "dda", "ew_pack", "blazemod", "Tanks", "No_Fungi", "no_flaming_weapons", "StatsThroughSkills"

It does seem that the very narrow room may be the cause or at least a circumstance conductive to the issue here.

[sparr]

I would reopen and flag as confirmed but someone revoked my dev/collaborator status :(

[Night-Pryanik]

As we have lots of variations of manually-drawn houses in json, I wonder whether we still need these procedurally-generated full-of-bugs houses at all.

[sparr]

I would not be happy removing the procedurally generated houses before having at least 500 unique static houses drawn.

[kevingranade]

It's much more likely that we'd swap in a new procedurally generated house method.