Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(s)mashing windows generates less sound than prying open windows/doors with a crowbar #10070

Closed
Chaz-Targrin opened this issue Nov 17, 2014 · 4 comments
Labels
<Bug> This needs to be fixed (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Chaz-Targrin
Copy link
Contributor

I've always been told that prying open doors and windows with a crowbar is the most quiet way to go about being sneaky in Cataclysm, however while using the crowbar generates 12 sound, (s)mashing the window only generates 4 sound. Also, in the event that I accidentally smash a window while trying to pry it open with a crowbar, it generates 24 sound.

Is it possible that the sound value for smashing windows in general was meant to be 24 but the 2 in front was forgotten? :o

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@KA101 KA101 added the Good First Issue This is a good first issue for a new contributor label Nov 17, 2014
@KA101
Copy link
Contributor

KA101 commented Nov 17, 2014

Probably.

@Mshock777
Copy link
Contributor

Actually no, in map.cpp line 1847 tells you that:

            if (destroy) {
                sound_volume = smax;
            } else {
                sound_volume = std::min(int(smin * 1.5), smax);

"str_min" for window is 3.
3*1.5 equals 4.5, which results in sound level of 4.

Also failed bashing results in sound level of 12.

        } else {
            sound_volume = 12;
            sound = _(bash->sound_fail.c_str());
            smashed_something = true;
        }

It is a good idea to move them both to json.

@KA101 KA101 added <Bug> This needs to be fixed and removed Good First Issue This is a good first issue for a new contributor labels Nov 25, 2014
@kevingranade kevingranade added the (S2 - Confirmed) Bug that's been confirmed to exist label Dec 8, 2014
@Oskar636
Copy link

Build 5900 windows 64bit console. For my character prying windows and doors made 12 noise, while smashing windows made 16 noise.

@Night-Pryanik
Copy link
Contributor

0.C-6369, Win 10 x64, curses. Prying - 7, smashing - 11.
Should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

6 participants