No alloc

[chpio]

Return a simple view instead of allocating a new string. It's a (partially) breaking change as the return type changes.

before:

test bench_gen_and_eq ... bench:          93 ns/iter (+/- 2)
test bench_write      ... bench:      11,200 ns/iter (+/- 396)

after:

test bench_gen_and_eq ... bench:          45 ns/iter (+/- 5)
test bench_write      ... bench:       5,018 ns/iter (+/- 166)

[Keruspe]

Can you rebase this please ?

[Keruspe]

Btw I think we shouldn't try to be too clever and just implement the default PartialEq + From<&str>

[chpio]

Can you rebase this please ?

yeap

Btw I think we shouldn't try to be too clever and just implement the default PartialEq + From<&str>

what do you mean by that? the PokemonUuid type should just implement a very small set of traits?

[Keruspe]

I don't see the point of having custom PartialEq implementations. Juste having the default one with #derive should be enough. With From<&str> implemented we can then use the default PartialEq against &str too by calling From on it.

…

On Sat, 29 Apr 2017 at 14:40, chpio ***@***.***> wrote: Can you rebase this please ? yeap Btw I think we shouldn't try to be too clever and just implement the default PartialEq + From<&str> what do you mean by that? the PokemonUuid type should just implement a very small set of traits? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANm3lhYz7mrd0AvHcWkhoffcTAZQLbXks5r0y-vgaJpZM4NMOTx> .

[chpio]

are you referring to something like this one:

uuid_to_pokemon(u).into() == "foo bar"

uuid_to_pokemon returning a PokemonUuid and then converting it into a string?

[Keruspe]

More like uuid_to_pokemon(u) == From::from("foo bar")

…

On Sat, 29 Apr 2017 at 14:47, chpio ***@***.***> wrote: are you referring to something like this one: uuid_to_pokemon(u).into() == "foo bar" — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANm3vPIMCmbZtkvdF_lCIAiAvd6Ae6yks5r0zFUgaJpZM4NMOTx> .

[chpio]

PokemonUuid::parse_str("foo bar").unwrap()

before (my 1. version):

test bench_eq      ... bench:       9,963 ns/iter (+/- 280)
test bench_eq_rand ... bench:       1,707 ns/iter (+/- 26)
test bench_write   ... bench:       4,965 ns/iter (+/- 97)

after:

test bench_eq      ... bench:       5,688 ns/iter (+/- 107)
test bench_eq_rand ... bench:       4,889 ns/iter (+/- 110)
test bench_write   ... bench:       5,059 ns/iter (+/- 179)

[chpio]

shit, it wasn't done. i had to first fix it for incompatible lifetimes (the #[derive(PartialEq)] impl has only one lifetime, but we need two)