-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Network Groups initial support #780
base: master
Are you sure you want to change the base?
Conversation
davlgd
commented
Jun 27, 2024
474ce8d
to
944ea07
Compare
🔎 A preview has been automatically published:
This preview will be deleted once this PR is closed. |
d878a4c
to
53ce5a9
Compare
7580d04
to
de9754b
Compare
b310ec4
to
e078da1
Compare
56e041d
to
e6c4a3b
Compare
e6c4a3b
to
3e9ab5f
Compare
3e9ab5f
to
653008d
Compare
0b255eb
to
a1a9736
Compare
4850c7c
to
fef1f02
Compare
Co-Authored-By: kannar <kannarfr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done David. I've seen some bugs and little improvments here and there.
I've raised the following:
- we may need to improve doc:
- maybe we could have a diagram showing 2 apps and 1 addon talking together and what's the difference between "with NG" and "without NG".
- we don't know what to do with the domain name.
- we don't have the receipe for adding an external peer and how to add it to the Wireguard. Even if we plan to ease this part with a deamon, I think we should add such a doc.
- we can only add app or addon from our personal organization (
checkMembersToLink
only looks into personal org). - we need to think about: does a ng bound to org A can link app from or B ?
- the
ng get-config
command does not work on aCleverPeer
Thanks for the review. Part of this will be covered by CC documentation and refined CT documentation/links to demos. I'll add this prior to release. |