Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Network Groups initial support #780

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[PoC] Network Groups initial support #780

wants to merge 10 commits into from

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Jun 27, 2024

⚠️ This is an experimental project to support Network groups ⚠️

@davlgd davlgd self-assigned this Jun 27, 2024
@davlgd davlgd requested a review from a team as a code owner June 27, 2024 14:50
@davlgd davlgd marked this pull request as draft June 27, 2024 14:51
@hsablonniere hsablonniere added this to the Experiments milestone Jun 27, 2024
@davlgd davlgd force-pushed the davlgd-new-ng branch 3 times, most recently from 474ce8d to 944ea07 Compare June 27, 2024 19:08
Copy link

github-actions bot commented Jun 27, 2024

🔎 A preview has been automatically published:

  • 🐧 linux 3dc35c9e3c74f6c0890b76b2bf80bead3fb56fbef50416ffaa379f2248b9dd1b
  • 🍏 macos 582ed0b42499ca708b626ce56619945e40015707c0755774d1c110ae0a3eeabb
  • 🪟 win 07b341a2da1b271ec23fa901a8c096164d13c5aeabbec9fd9d53698507590b52

This preview will be deleted once this PR is closed.

@davlgd davlgd force-pushed the davlgd-new-ng branch 7 times, most recently from d878a4c to 53ce5a9 Compare July 4, 2024 23:48
@davlgd davlgd force-pushed the davlgd-new-ng branch 3 times, most recently from 7580d04 to de9754b Compare October 23, 2024 13:59
@davlgd davlgd force-pushed the davlgd-new-ng branch 6 times, most recently from 56e041d to e6c4a3b Compare December 7, 2024 00:06
@davlgd davlgd force-pushed the davlgd-new-ng branch 3 times, most recently from 0b255eb to a1a9736 Compare January 10, 2025 16:26
@davlgd davlgd force-pushed the davlgd-new-ng branch 2 times, most recently from 4850c7c to fef1f02 Compare January 26, 2025 07:59
Copy link
Collaborator

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done David. I've seen some bugs and little improvments here and there.

I've raised the following:

  • we may need to improve doc:
    • maybe we could have a diagram showing 2 apps and 1 addon talking together and what's the difference between "with NG" and "without NG".
    • we don't know what to do with the domain name.
    • we don't have the receipe for adding an external peer and how to add it to the Wireguard. Even if we plan to ease this part with a deamon, I think we should add such a doc.
  • we can only add app or addon from our personal organization (checkMembersToLink only looks into personal org).
  • we need to think about: does a ng bound to org A can link app from or B ?
  • the ng get-config command does not work on a CleverPeer

bin/clever.js Outdated Show resolved Hide resolved
bin/clever.js Outdated Show resolved Hide resolved
bin/clever.js Outdated Show resolved Hide resolved
bin/clever.js Outdated Show resolved Hide resolved
bin/clever.js Outdated Show resolved Hide resolved
src/experimental-features.js Outdated Show resolved Hide resolved
docs/ng.md Outdated Show resolved Hide resolved
src/models/ng.js Show resolved Hide resolved
docs/ng.md Outdated Show resolved Hide resolved
src/commands/ng.js Outdated Show resolved Hide resolved
@davlgd davlgd marked this pull request as ready for review January 30, 2025 14:58
@davlgd davlgd requested a review from pdesoyres-cc January 30, 2025 15:45
@davlgd
Copy link
Contributor Author

davlgd commented Jan 30, 2025

Well done David. I've seen some bugs and little improvments here and there.

I've raised the following:

  • we may need to improve doc:

    • maybe we could have a diagram showing 2 apps and 1 addon talking together and what's the difference between "with NG" and "without NG".
    • we don't know what to do with the domain name.
    • we don't have the receipe for adding an external peer and how to add it to the Wireguard. Even if we plan to ease this part with a deamon, I think we should add such a doc.
  • we can only add app or addon from our personal organization (checkMembersToLink only looks into personal org).

  • we need to think about: does a ng bound to org A can link app from or B ?

  • the ng get-config command does not work on a CleverPeer

Thanks for the review. Part of this will be covered by CC documentation and refined CT documentation/links to demos. I'll add this prior to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants