fix signature check if response contains attributes with windows style endings #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From my reading, yes, it would be more proper to validate the signature against But, Changing this to the original would break parsing. Updating Please comment if this is not the case. |
|
@mcab We've had issues with SAML Assertions coming from simpleSamlPHP with windows-style line breaks in attributes. Running patched version in production. With that said, we'll try 4.0.0 in the next few weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with signature check if SAML Response has \r\n style endings (for example in attributes). The signature check should run against raw decoded XML.