-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Github enterprise #74
Conversation
@Line-Noise @gtorre @VasuBhaskar hoping to land this soon.
Thank you! -- Personally, I still haven't had a chance to get a working setup for Github enterprise. The simplest option for me seems like it would require running it myself on AWS. I've also reached out to their developer program seeking a developer license to work on enterprise, instead of using a free trial for Github enterprise. |
I'm happy to give this a test. I'm not sure about the upload URL. I doubt it's different but I don't know how to check. |
@nathanleiby I'd be happy to test the changes.
Same URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, assuming the testing works as expected!
Ran I haven't tested Enterprise myself, but at that point can handoff to others for their help in testing 🙏 Thank you! |
@Line-Noise @gtorre Thanks for being able to help test! I've shipped a release here based on this change: https://github.com/Clever/microplane/releases/tag/v0.0.28 To use Github enterprise, download this new release, then use it to run:
I don't expect problems other than "it doesn't work", as there's no special logic here other than setting up the Github Enterprise client. It's using the same API calls we've tested with non-enterprise Github. Still please understand that I haven't tested this feature myself so be cautious if anything seems amiss. Thanks again! |
@nathanleiby thanks! I downloaded the darwin binary and getting this error:
|
@gtorre Sorry for the confusion! Can you try creating a file named
for example at Clever this might look like:
Once you've created that file, run:
|
@nathanleiby happy to report that it worked!
|
@gtorre glad to hear it and thank you for testing! |
JIRA
n/a
Overview
Allows microplane to work with Github enterprise.
Caveat noted in README: Self-hosted Github setup with different URLs for the main API and uploads API are not yet supported. If this is a blocker for you, please file an issue or make a PR.
Testing