Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix search scrolling with wider Unicode characters. #938

Merged
merged 3 commits into from
Dec 31, 2022

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Dec 31, 2022

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

This should help make search scrolling more reliable larger Unicode characters like CJK/flag characters.

Issue

If applicable, what issue does this address?

Closes: #882

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

I don't even remember why I defined this, but I don't think it's really
necessary.
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2022

Codecov Report

Base: 19.64% // Head: 20.76% // Increases project coverage by +1.11% 🎉

Coverage data is based on head (8b6a336) compared to base (efcf2bd).
Patch coverage: 57.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   19.64%   20.76%   +1.11%     
==========================================
  Files          75       75              
  Lines       14558    14576      +18     
==========================================
+ Hits         2860     3026     +166     
+ Misses      11698    11550     -148     
Impacted Files Coverage Δ
src/app.rs 0.00% <0.00%> (ø)
src/app/query.rs 0.00% <0.00%> (ø)
src/canvas/drawing_utils.rs 100.00% <ø> (+25.00%) ⬆️
src/canvas/widgets/process_table.rs 0.00% <0.00%> (ø)
src/components/data_table/state.rs 33.33% <0.00%> (+0.98%) ⬆️
src/widgets/process_table.rs 14.02% <0.00%> (+1.01%) ⬆️
src/app/states.rs 54.57% <81.25%> (+54.57%) ⬆️
src/utils/gen_util.rs 87.39% <93.33%> (+0.23%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang changed the title bug: fix search scrolling with CJK/flag characters bug: fix search scrolling with wider Unicode characters. Dec 31, 2022
@ClementTsang ClementTsang marked this pull request as ready for review December 31, 2022 10:50
@ClementTsang ClementTsang merged commit 3b57741 into master Dec 31, 2022
@ClementTsang ClementTsang deleted the fix_search_scroll branch December 31, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Search bar scroll behaves strangely with CJK/flags
2 participants