-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding default expanded option to commandline and config (closes #822) #919
Adding default expanded option to commandline and config (closes #822) #919
Conversation
Codecov ReportBase: 19.24% // Head: 20.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #919 +/- ##
==========================================
+ Coverage 19.24% 20.07% +0.82%
==========================================
Files 74 74
Lines 14069 14246 +177
==========================================
+ Hits 2708 2860 +152
- Misses 11361 11386 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for the PR, will check in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long, left a few small comments, mostly just nitpicking.
EDIT: Also did a quick check on my Linux machine for sanity's sake, seems fine functionality-wise.
Thank you for this! Will you make a new release soon? Just wondering if I should clone the branch and build it myself, or wait for an official release (if one of coming soon). |
@alexleduc76 I want to get an official stable release out before end of year. That being said I have daily nightly builds automatically created that might be of interest at https://github.com/ClementTsang/bottom/releases/tag/nightly |
@ClementTsang updated |
Looks good, thanks for everything! @all-contributors please add @sou-chon for code. |
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @sou-chon! 🎉 |
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Addresses #822: Adding option to expand widgets on startup. Also adding the corresponding option to config file.
Issue
If applicable, what issue does this address?
Closes: #822
Testing
If relevant, please state how this was tested. All changes must be tested to work:
testing by
debug_assert()
fromclap
.If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)