bug: Tests try to modify user home directory #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where running `cargo test` would try to create a configuration file for the user.
|
Thanks for catching this, totally didn't think about this as a problem. Change LGTM. Also tested on my own system and this does fix the issue. @all-contributors add @yellowsquid for code |
|
I've put up a pull request to add @yellowsquid! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where running
cargo testwould try to create a configuration file for the user.Issue
Closes: #535
Testing
Walked through the steps to reproduce from #535. All tests now pass.
Tested on these platforms:
Checklist
The following have been met:
cargo fmt)