Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix bugs with disk widget and disk encryption #423

Merged
merged 17 commits into from
Feb 25, 2021

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 25, 2021

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Two issues were highlighted as a result of using either Void Linux with disk encryption, or just disk encryption on Linux in general:

Two fixes:

  1. Fixes a failed usage() call in the get_disk_usage function from failing the entire result. Now it only returns an entry with N/A results. This occurred in some distros and disk encryption setups, for example, the one for Void Linux.
  2. Fixes a potential mapping issue with disk encryption on Linux in general. Since the disk might map to /dev/mapper/whatever, but the I/O harvester was using another name, the mappings would not match. As such, we now also check if a symlink exists; if it does, then we take it and work out the correct path. This also fixes the disk name being wrong.

Void Linux + LUKS:
image

PopOS with disk encryption:
image

Issue

If applicable, what issue does this address?

#419

Type of change

Remove the irrelevant ones:

  • Bug fix (non-breaking change which fixes an issue)

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes CI pipeline (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang
Copy link
Owner Author

...please ignore the commit history, I was lazy and so did my debugging tests using git to sync my main machine and my VM...

@ClementTsang ClementTsang merged commit fe74328 into master Feb 25, 2021
@ClementTsang ClementTsang deleted the void_linux_luks_disks branch February 25, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant