Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: remove buggy auto-generated CPU colour implementation #308

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Nov 18, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Removes the random automatically generated colours for the CPU metrics. This was not supported in all terminal emulators, and would cause some of them to break (namely macOS Terminal).

Instead we'll default to colours we can be more certain will work and loop through them as required. Users can still override these colours with their own.

Issue

If applicable, what issue does this address?

Closes: #307

Type of change

Remove the irrelevant ones:

  • Bug fix (non-breaking change which fixes an issue)

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes Travis tests (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang ClementTsang marked this pull request as ready for review November 19, 2020 00:04
@ClementTsang
Copy link
Owner Author

Tested by SSHing into my 16-core Linux machine from my MBP. Didn't seem to be broken.

@ClementTsang ClementTsang merged commit c0a8c34 into master Nov 19, 2020
@ClementTsang ClementTsang deleted the auto_colour_fix branch November 19, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text and Graph colors transparent
1 participant