Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add simple indicator for when data updating is frozen #269

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Oct 18, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Adds a simple indicator to help users know when they've frozen data updating using f. For example:

image

image

image

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • New feature (non-breaking change which adds functionality)

Test methodology

If relevant, please state how this was tested:

  • Tested on Linux for basic, expanded, and normal modes, where it should show up.
  • It should not show up for the dd and help dialogs.

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes Travis tests (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang ClementTsang merged commit 05b39d2 into master Oct 18, 2020
@ClementTsang ClementTsang deleted the frozen_indication branch October 18, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant