Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add appox. total mem as an option for processes and basic mem #188

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 17, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Adds a way to display the memory value as a column in the processes widget and the basic memory widget, rather than just the percentage.

Issue

If applicable, what issue does this address?

Closes: #169

Type of change

Remove the irrelevant ones:

  • New feature (non-breaking change which adds functionality)

Test methodology

If required, please state how this was tested:

  • Test on all platforms
    • Test if things like sorting work

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

@ClementTsang ClementTsang changed the title feature: Add appox. total mem to processes as column feature: Add appox. total mem as an option for columns and basic mem Aug 17, 2020
@ClementTsang ClementTsang changed the title feature: Add appox. total mem as an option for columns and basic mem feature: Add appox. total mem as an option for processes and basic mem Aug 17, 2020
@ClementTsang ClementTsang merged commit 3c373d7 into master Aug 17, 2020
@ClementTsang ClementTsang deleted the show_proc_memory_values branch August 17, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to display memory values rather than percentage
1 participant