Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systematic updates to lemmas #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

systematic updates to lemmas #129

wants to merge 2 commits into from

Conversation

RickBrannan
Copy link
Contributor

  • lemma for suffixed pronoun
  • lemma for aramaic suffixed pronoun
  • use MARBLE / ETCBC lemma when disagreement in consonants
  • correct two specific lemma instances

* lemma for suffixed pronoun
* lemma for aramaic suffixed pronoun
* use MARBLE / ETCBC lemma when disagreement in consonants
* correct two specific lemma instances
@jonathanrobie jonathanrobie self-requested a review December 4, 2024 17:32
Copy link
Contributor

@jonathanrobie jonathanrobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better. Some of the lemmas still have cantillation marks - I assume that is true of the original ETCBC data?

Here is a filtered list of all occurrences of marks in your dataset that should not occur in lemmas, grouped by the mark:


1. Silluq (ֽ)

  • יְבֶמֶתֽ
  • יְבֶרֶכְיָהוּֽ
  • יֶרֶדֽ
  • יַבֶּשֶׁתֽ

2. Sof Pasuq (׃)

  • None identified in this dataset.

3. Etnachta (֑)

  • חַיִל֑
  • חֲצֵרֹות֑

4. Zakef Gadol (֔)

  • מֹשֶׁ֔ה
  • יִשְׂרָאֵ֔ל

5. Zakef Katon (֕)

  • יִשָּׂשׂכָ֕ר

6. Revia (֗)

  • אֵשֶׁר֗

7. Munach (֣)

  • בְּרִית֣

8. Tifcha (֖)

  • בָּר֖וּךְ

9. Merkha (֥)

  • יִצְחָק֥

10. Mahapakh (֤)

  • חֲזָ֤ק
  • יְהוּדָ֤ה

11. Gershayim (֞)

  • יִשְׁמַע֞
  • יִשְׁרָאֵל֞

12. Kadma (֙)

  • יַעֲקֹב֙

13. Telisha Gedola (֓)

  • יָשׁ֓ב

@jacobwegner
Copy link
Collaborator

I may have spare cycles this week to do some of the "automate TSV and lowfat updates" when nodes changes work, but until then, happy to be on the hook to do that once @RickBrannan and @jonathanrobie resolve any remaining feedback.

  • TSV
basex -i WLC/nodes/macula-hebrew.xml \
    -o WLC/tsv/macula-hebrew.tsv \
    WLC/tsv/hebrew-nodes-to-tsv.xq
  • Lowfat
cd pipelines/lowfat-transform
poetry install
poetry run python main.py WLC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants