Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LivingSetAttackEvent #29

Open
wants to merge 13 commits into
base: experimental/foundation
Choose a base branch
from

Conversation

Ecdcaeb
Copy link
Contributor

@Ecdcaeb Ecdcaeb commented Jan 7, 2024

enable change the target in the event.
the existed hook is @Deprecated

Why I edit this event

The old event do not imple the redirection of target. When our mod involves it we have to use reflection or AT.

Why the old hook remained

I noticed that

//Optifine Helper Functions u.u, these are here specifically for Optifine
//Note: When using Optifine, these methods are invoked using reflection, which
//incurs a major performance penalty.

@Ecdcaeb Ecdcaeb changed the base branch from main to experimental/foundation June 6, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant