Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra quest frames redux #115

Merged
merged 13 commits into from
Jun 26, 2024
Merged

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • Remove PresetTexture.QUEST_AUX_*.
  • Add many extra icons for quest frame.
  • Separate flip-"isMain" button and change-quest-frame button.
  • Add the new gui to select a quest frame.
  • fix loadLegacy not targeting the correct file.
  • make main describe itself as something which increases link line size.

difference from #102:

  • fix loadLegacy not targeting the correct file.
  • make main describe itself as something which increases link line size.
  • remove the DEFAULT option, default is now ROUNDED_SQUARE.
  • main no longer impacts appearance of the frame. when loading a save without a frame type, the frame type is set to ROUNDED_SQUARE or GATE depending on the main value.
  • adds EMPTY, which is frame type which has no background.
  • make advancement dump command use the new frames.
  • improve the new gui's display of frame states.

supersedes #102

image

@WaitingIdly WaitingIdly added the enhancement New feature or request label May 16, 2024
@Rongmario Rongmario merged commit daa263a into CleanroomMC:1.12 Jun 26, 2024
@WaitingIdly WaitingIdly deleted the extra-frames branch July 6, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants