Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change display for plugins and themes passing cpcs #29

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

xxsimoxx
Copy link
Member

@xxsimoxx xxsimoxx commented Jul 1, 2024

I've added cpcs_status to plugin and theme CPT.
It contains passed if cpcs is passing.
Also added the meta to REST API.

This PR is a draft that uses this new information to give more prestige to plugins/themes having a passing cpcs GitHub workflow.

Colors and icon chan be changed and it misses a11y and explanation.

image image

@xxsimoxx xxsimoxx added the help wanted Extra attention is needed label Jul 1, 2024
@xxsimoxx xxsimoxx requested a review from KTS915 October 17, 2024 06:58
Copy link
Member

@KTS915 KTS915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm not sure what you mean by "needs a11y", but the color contrast is fine in my testing. We can debate where to add the explanation afterwards.

@xxsimoxx xxsimoxx removed the help wanted Extra attention is needed label Oct 18, 2024
@xxsimoxx xxsimoxx merged commit 46aa9f2 into ClassicPress:main Oct 18, 2024
1 check passed
@xxsimoxx xxsimoxx deleted the vetted branch October 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants