WP-r42632: Themes: Use api v. 1.2 to query theme information. #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theme information. See https://core.trac.wordpress.org/ticket/43192. Conflicts: - src/wp-admin/includes/theme.php - src/wp-includes/class-wp-customize-manager.php --- Merges https://core.trac.wordpress.org/changeset/42632 / WordPress/wordpress-develop@212c880d71 to ClassicPress.
xxsimoxx
added
type: wp backport
|
This is an alternative to #1195. |
…write` property exists in `Theme_Upgrader::install_strings()`. This ensures consistency with `Plugin_Upgrader::install_strings()` and resolves an issue caused by the property not existing in other upgrader implementations. WP:Props schlessera, azaozz. See https://core.trac.wordpress.org/ticket/50670. --- Merges https://core.trac.wordpress.org/changeset/48493 / WordPress/wordpress-develop@da730fce4d to ClassicPress.
mattyrob
approved these changes
Dec 16, 2022
|
LGTM - Tests out well, no issues seen. |
mattyrob
added
task: needs 2nd review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP-r42632: Themes: Use api.wordpress.org/themes/info/1.2/ to query theme information.
See https://core.trac.wordpress.org/ticket/43192.
Also Hide console logging in Theme Installer.
To fix a warning that came out testing this backport added to PR:
WP-r48493: Upgrade/Install: Check if the theme installer skin's
overwriteproperty exists inTheme_Upgrader::install_strings().This ensures consistency with
Plugin_Upgrader::install_strings()and resolves an issue caused by the property not existing in other upgrader implementations.