Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add x86 images #9

Merged
merged 1 commit into from
Apr 26, 2020
Merged

add x86 images #9

merged 1 commit into from
Apr 26, 2020

Conversation

nickdesaulniers
Copy link
Member

The config is copied from buildroot/x86_64.config modulo CONFIG_64B.

Boot tested with a 32b x86 Clang built kernel in qemu.

Signed-off-by: Nick Desaulniers ndesaulniers@google.com

The config is copied from buildroot/x86_64.config modulo CONFIG_64B.

Boot tested with a 32b x86 Clang built kernel in qemu.

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
@nickdesaulniers
Copy link
Member Author

should help ClangBuiltLinux/continuous-integration#182

note, I don't see /proc/version in interactive mode, but that's just another bug to chase.

Copy link
Member

@nathanchance nathanchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nickdesaulniers nickdesaulniers merged commit 6ae3da1 into master Apr 26, 2020
@nickdesaulniers nickdesaulniers deleted the i386_2 branch April 26, 2020 22:39
@nathanchance
Copy link
Member

note, I don't see /proc/version in interactive mode, but that's just another bug to chase.

mount -t proc proc /proc

When we jump straight into a shell, init does not run to automatically mount all of those systems.

nathanchance added a commit to nathanchance/boot-utils that referenced this pull request Apr 27, 2020
This was missed in ClangBuiltLinux#9.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
@nickdesaulniers
Copy link
Member Author

oh, I didn't realize that init was mounting proc. makes sense

@tpimh
Copy link

tpimh commented Apr 27, 2020

That's practically identical to my i386 branch.

@nickdesaulniers
Copy link
Member Author

ah, sorry I didn't see it @tpimh , send those PRs ASAP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants