boot-utils: Python updates #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-strings is the preferred method for printing formatted strings with Python 3.6+. 3.6 was released almost six years ago and has been EOL for almost a year now, so this should have little impact. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
It is not immediately obvious why as_posix() is being called in most situations and it is often unnecessary, as subprocess.Popen() and friends have supported path-like objects without 'shell=True' since Python 3.6. Eliminate all these calls, which simplifies everything. However, path-like objects are not iterable, so explicit conversions to str are added in places where they need to be in lieu of calling as_posix(), which appears to be preferred based on my interpretation of the pathlib documentation. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages should be self explanatory but this PR updates boot-utils to use f-strings (preferred in Python 3.6+) and eliminates as_posix() calls on path objects (possible after Python 3.6+), which cleans up the code a bit.