boot-utils: Add support for booting Debian images #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'-cpu max' is treated as '-cpu host' when KVM is enabled. Link: https://gitlab.com/qemu-project/qemu/-/commit/bab52d4bba3f22921a690a887b4bd0342f2754cd Signed-off-by: Nathan Chancellor <nathan@kernel.org>
* -machine "virtualiation=true" allows the virtual machine to spawn virtual guests, which can be useful for verifying KVM without an actual arm64 piece of hardware. This only works when KVM is not being used though so it is only enabled when not on an arm64 host. * -machine "virt,gic-version=max" will use the newest Generic Interrupt Controller available. These were taken from Will Deacon's QEMU guide and it was tested on Debian Buster with Debian's QEMU package and a self compiled tip of tree version. Link: https://mirrors.edge.kernel.org/pub/linux/kernel/people/will/docs/qemu/qemu-arm64-howto.html Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Purely aesthetic. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Feb 20, 2021
There are times where there is a need to have a fuller environment for testing, rather than the simple Busybox based rootfs that is normally used. Introduce a Debian build script, which uses debootstrap and qemu-user-static to generate a bootable rootfs image. boot-qemu.sh is modified accordingly to support this image if the user wants it. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
force-pushed
the
debootstrap
branch
from
aa6f659 to
381b188
Compare
|
I added support for Additionally, I fixed an issue where |
msfjarvis
approved these changes
Feb 20, 2021
| @@ -137,8 +155,11 @@ function setup_qemu_args() { | |||
| arm32_v7) | |||
| ARCH=arm | |||
| APPEND_STRING+="console=ttyAMA0 " | |||
| # https://lists.nongnu.org/archive/html/qemu-discuss/2018-08/msg00030.html | |||
| # VFS: Cannot open root device "vda" or unknown-block(0,0): error -6 | |||
| ${DEBIAN} && HIGHMEM=,highmem=off | |||
There was a problem hiding this comment.
should the value assigned to HIGHMEM be a quoted string?
There was a problem hiding this comment.
shellcheck does not complain but I can update that if you feel it is worthwhile.
| @@ -1,2 +1 @@ | |||
| qemu-binaries/ | |||
| rootfs.cpio | |||
There was a problem hiding this comment.
doesn't this mean then that each time we decompress an initrd, that the directory is now dirty?
There was a problem hiding this comment.
No, I just moved it to images/.gitignore.
|
Looks cool! |
Reported-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Suggested-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Requested-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Suggested-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Suggested-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
force-pushed
the
debootstrap
branch
from
765951c to
ce8b8a1
Compare
nickdesaulniers
approved these changes
Feb 22, 2021
|
Thank you both for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these commits should be self explanatory.