boot-qemu.sh: Combine x86 and x86_64 for shared KVM handling #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
reviewed
May 3, 2020
The x86 section unconditionally adds -enable-kvm to the QEMU flags. This won't work for Travis because it does not have KVM support. The x86_64 section handles this already and the only difference between the x86 and x86_64 sections is the QEMU binary name. Combine the sections and handle that so that there is less duplication and everything works properly. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nathanchance
force-pushed
the
fix-x86-travis
branch
from
5580bfa to
485a205
Compare
tpimh
approved these changes
May 4, 2020
|
cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The x86 section unconditionally adds -enable-kvm to the QEMU flags. This
won't work for Travis because it does not have KVM support. The x86_64
section handles this already and the only difference between the x86 and
x86_64 sections is the QEMU binary name. Combine the sections and handle
that so that there is less duplication and everything works properly.