-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from JustArchiNET:main #378
base: main
Are you sure you want to change the base?
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3ba8602 - Browse repository at this point
Copy the full SHA 3ba8602View commit details
Commits on Aug 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 30c84ef - Browse repository at this point
Copy the full SHA 30c84efView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3dbfc5 - Browse repository at this point
Copy the full SHA d3dbfc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ed05b8 - Browse repository at this point
Copy the full SHA 3ed05b8View commit details
Commits on Aug 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a8e209 - Browse repository at this point
Copy the full SHA 7a8e209View commit details -
Configuration menu - View commit details
-
Copy full SHA for 332e9a5 - Browse repository at this point
Copy the full SHA 332e9a5View commit details
Commits on Aug 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 08907e8 - Browse repository at this point
Copy the full SHA 08907e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 773698a - Browse repository at this point
Copy the full SHA 773698aView commit details -
Configuration menu - View commit details
-
Copy full SHA for afa602f - Browse repository at this point
Copy the full SHA afa602fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d90aa17 - Browse repository at this point
Copy the full SHA d90aa17View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd7c86c - Browse repository at this point
Copy the full SHA fd7c86cView commit details
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f983a2e - Browse repository at this point
Copy the full SHA f983a2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ff1411 - Browse repository at this point
Copy the full SHA 4ff1411View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cb3123 - Browse repository at this point
Copy the full SHA 4cb3123View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd00911 - Browse repository at this point
Copy the full SHA bd00911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67d9486 - Browse repository at this point
Copy the full SHA 67d9486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c3c4c0 - Browse repository at this point
Copy the full SHA 0c3c4c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce4b41e - Browse repository at this point
Copy the full SHA ce4b41eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f05d041 - Browse repository at this point
Copy the full SHA f05d041View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cde913 - Browse repository at this point
Copy the full SHA 4cde913View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac9c150 - Browse repository at this point
Copy the full SHA ac9c150View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ad8a93 - Browse repository at this point
Copy the full SHA 5ad8a93View commit details
Commits on Aug 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2c9d015 - Browse repository at this point
Copy the full SHA 2c9d015View commit details -
Configuration menu - View commit details
-
Copy full SHA for f28d783 - Browse repository at this point
Copy the full SHA f28d783View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67329ec - Browse repository at this point
Copy the full SHA 67329ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f0e670 - Browse repository at this point
Copy the full SHA 3f0e670View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41d03a1 - Browse repository at this point
Copy the full SHA 41d03a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for df3f16d - Browse repository at this point
Copy the full SHA df3f16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28e9247 - Browse repository at this point
Copy the full SHA 28e9247View commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 568e993 - Browse repository at this point
Copy the full SHA 568e993View commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 216cd51 - Browse repository at this point
Copy the full SHA 216cd51View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff7a1e7 - Browse repository at this point
Copy the full SHA ff7a1e7View commit details
Commits on Aug 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 599ca4d - Browse repository at this point
Copy the full SHA 599ca4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bae8dc3 - Browse repository at this point
Copy the full SHA bae8dc3View commit details
Commits on Aug 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 90f2d93 - Browse repository at this point
Copy the full SHA 90f2d93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ad8183 - Browse repository at this point
Copy the full SHA 8ad8183View commit details
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2100d62 - Browse repository at this point
Copy the full SHA 2100d62View commit details
Commits on Aug 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9540e56 - Browse repository at this point
Copy the full SHA 9540e56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91aaf3b - Browse repository at this point
Copy the full SHA 91aaf3bView commit details -
chore(deps): update dependency microsoft.codeanalysis.resxsourcegener…
…ator to v3.11.0-beta1.24324.1
Configuration menu - View commit details
-
Copy full SHA for cb0767f - Browse repository at this point
Copy the full SHA cb0767fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f331ee2 - Browse repository at this point
Copy the full SHA f331ee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0cc53c - Browse repository at this point
Copy the full SHA a0cc53cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1639418 - Browse repository at this point
Copy the full SHA 1639418View commit details
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 85c4e4a - Browse repository at this point
Copy the full SHA 85c4e4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecaf612 - Browse repository at this point
Copy the full SHA ecaf612View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a678cd - Browse repository at this point
Copy the full SHA 6a678cdView commit details
Commits on Aug 16, 2024
-
Add workaround for LINQ race condition with concurrent collections
This is some next-level race condition, so for those interested: - Concurrent collections are thread-safe in a way that each operation is atomic - Naturally if you call two atomic operations in a row, the result is no longer atomic, since there could be some changes between the first and the last - Certain LINQ operations such as OrderBy(), Reverse(), ToArray(), among more, use internal buffer for operation with certain optimization that checks if input is ICollection, if yes, it calls Count and CopyTo(), for OrderBy in this example - In result, such LINQ call is not guaranteed to be thread-safe, since it assumes those two calls to be atomic, while they're not in reality. This issue is quite hard to spot in real applications, since it's not that easy to trigger it (you need to call the operation on ICollection and then have another thread modifying it while enumerating). This is probably why we've never had any real problem until I've discovered this madness with @Aareksio in entirely different project. As a workaround, we'll explicitly convert some ICollection inputs to IEnumerable, in particular around OrderBy(), so the optimization is skipped and the result is not corrupted. I've added unit tests which ensure this workaround works properly, and you can easily reproduce the problem by removing AsLinqThreadSafeEnumerable() in them. See dotnet/runtime#50687 for more insight I have no clue who thought that ignoring this issue is a good idea, at the very least concurrent collections should have opt-out mechanism from those optimizations, there is no reason for them to not do that.
Configuration menu - View commit details
-
Copy full SHA for b6805a9 - Browse repository at this point
Copy the full SHA b6805a9View commit details -
No point in making this available for all IEnumerables, only ICollections are affected
Configuration menu - View commit details
-
Copy full SHA for 5a41d55 - Browse repository at this point
Copy the full SHA 5a41d55View commit details
Commits on Aug 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 90cfdd1 - Browse repository at this point
Copy the full SHA 90cfdd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06185d5 - Browse repository at this point
Copy the full SHA 06185d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 337b720 - Browse repository at this point
Copy the full SHA 337b720View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5605e9a - Browse repository at this point
Copy the full SHA 5605e9aView commit details
Commits on Aug 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5867a35 - Browse repository at this point
Copy the full SHA 5867a35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dc853e - Browse repository at this point
Copy the full SHA 2dc853eView commit details -
Allow nullable T for concurrent list
Even if we don't use it, no reason to not support it, since it is in underlying collection
Configuration menu - View commit details
-
Copy full SHA for fab9d95 - Browse repository at this point
Copy the full SHA fab9d95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0846291 - Browse repository at this point
Copy the full SHA 0846291View commit details
Commits on Aug 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ebac577 - Browse repository at this point
Copy the full SHA ebac577View commit details -
Drop VS public signing workaround
They had enough of time to fix their stupidity
Configuration menu - View commit details
-
Copy full SHA for 6b2bcbe - Browse repository at this point
Copy the full SHA 6b2bcbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 023c7da - Browse repository at this point
Copy the full SHA 023c7daView commit details -
Configuration menu - View commit details
-
Copy full SHA for cab8c60 - Browse repository at this point
Copy the full SHA cab8c60View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c07caf6 - Browse repository at this point
Copy the full SHA c07caf6View commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe1cdce - Browse repository at this point
Copy the full SHA fe1cdceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fb19bf - Browse repository at this point
Copy the full SHA 9fb19bfView commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4156dfc - Browse repository at this point
Copy the full SHA 4156dfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d73b42 - Browse repository at this point
Copy the full SHA 3d73b42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97a8e6f - Browse repository at this point
Copy the full SHA 97a8e6fView commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d85c9a3 - Browse repository at this point
Copy the full SHA d85c9a3View commit details
Commits on Aug 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77ec0d1 - Browse repository at this point
Copy the full SHA 77ec0d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5194cb1 - Browse repository at this point
Copy the full SHA 5194cb1View commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c7fa69a - Browse repository at this point
Copy the full SHA c7fa69aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a155748 - Browse repository at this point
Copy the full SHA a155748View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1438848 - Browse repository at this point
Copy the full SHA 1438848View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f42c75 - Browse repository at this point
Copy the full SHA 2f42c75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3da662e - Browse repository at this point
Copy the full SHA 3da662eView commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c84db87 - Browse repository at this point
Copy the full SHA c84db87View commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d750ba5 - Browse repository at this point
Copy the full SHA d750ba5View commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb6f9f3 - Browse repository at this point
Copy the full SHA cb6f9f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b46e55c - Browse repository at this point
Copy the full SHA b46e55cView commit details
Commits on Sep 1, 2024
-
chore(deps): update asf-ui digest to ef232d5 (#3277)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9898d47 - Browse repository at this point
Copy the full SHA 9898d47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54a092a - Browse repository at this point
Copy the full SHA 54a092aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a95a69 - Browse repository at this point
Copy the full SHA 4a95a69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ae59f4 - Browse repository at this point
Copy the full SHA 1ae59f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c61f8 - Browse repository at this point
Copy the full SHA 63c61f8View commit details
Commits on Sep 2, 2024
-
chore(deps): update asf-ui digest to 486401d (#3279)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a3d968c - Browse repository at this point
Copy the full SHA a3d968cView commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1fbc51d - Browse repository at this point
Copy the full SHA 1fbc51dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7910205 - Browse repository at this point
Copy the full SHA 7910205View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dc6096 - Browse repository at this point
Copy the full SHA 7dc6096View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 720a24e - Browse repository at this point
Copy the full SHA 720a24eView commit details -
chore(deps): update asf-ui digest to 65b5c0c (#3281)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c0da86e - Browse repository at this point
Copy the full SHA c0da86eView commit details -
Configuration menu - View commit details
-
Copy full SHA for efdc3eb - Browse repository at this point
Copy the full SHA efdc3ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for db920da - Browse repository at this point
Copy the full SHA db920daView commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c5e0a2 - Browse repository at this point
Copy the full SHA 6c5e0a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c4d298 - Browse repository at this point
Copy the full SHA 2c4d298View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a02d8ce - Browse repository at this point
Copy the full SHA a02d8ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for c26a758 - Browse repository at this point
Copy the full SHA c26a758View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e65142 - Browse repository at this point
Copy the full SHA 8e65142View commit details
Commits on Sep 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0d3bc2c - Browse repository at this point
Copy the full SHA 0d3bc2cView commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5f545a9 - Browse repository at this point
Copy the full SHA 5f545a9View commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aa1cd98 - Browse repository at this point
Copy the full SHA aa1cd98View commit details -
Configuration menu - View commit details
-
Copy full SHA for c477bd2 - Browse repository at this point
Copy the full SHA c477bd2View commit details -
chore(deps): update dependency microsoft.codeanalysis.resxsourcegener…
…ator to 3.11.0-beta1.24415.1
Configuration menu - View commit details
-
Copy full SHA for d8ad42f - Browse repository at this point
Copy the full SHA d8ad42fView commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1714bd2 - Browse repository at this point
Copy the full SHA 1714bd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3812331 - Browse repository at this point
Copy the full SHA 3812331View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a8359e3 - Browse repository at this point
Copy the full SHA a8359e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d0f5a5 - Browse repository at this point
Copy the full SHA 4d0f5a5View commit details
Commits on Sep 13, 2024
-
Add
loot&
andtransfer&
commands (#3287)* Add `loot&` and `transfer&` commands * Remove trailing comment
Configuration menu - View commit details
-
Copy full SHA for 8e85b87 - Browse repository at this point
Copy the full SHA 8e85b87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bb8361 - Browse repository at this point
Copy the full SHA 3bb8361View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73d756f - Browse repository at this point
Copy the full SHA 73d756fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 061e61b - Browse repository at this point
Copy the full SHA 061e61bView commit details -
Fix reconnection with connection being lost
After changes regarding to callbacks handling, we accidentally broke the reconnection logic. In particular, forced connection implicitly did disconnect with disconnect callback, but disconnect callback killed our callbacks handling loop for future connection since it was instructed to not reconnect... Pretty convulated logic. Let's attempt to fix and simplify it. There is no forced connection concept anymore, but rather a new reconnect function which either, triggers reconnection through usual disconnection logic, or connects in edge case if we attempted to reconnect with already disconnnected client. This way the status transition is more predictable, as we Connect() only in 3 cases: - Initial start, including !start command, when we actually spawn the callbacks handling loop - Upon disconnection, if we're configured to reconnect - Reconnection, in case we're already disconnected and can't use above And we use reconnect when: - Failure in heartbeats to detect disconnections sooner - Failure in refreshing access tokens, since if we lose our refresh token then the only way to get a new one is to reconnect And finally disconnect is triggered when: - Stopping the bot, especially !stop - Bulletproofing against trying to connect when !KeepRunning and likewise - Usual Steam maintenance and other network issues (which usually trigger reconnection) The codebase is too huge to analyze every possible edge case, but with this logic I can no longer reproduce the previous issue
Configuration menu - View commit details
-
Copy full SHA for cefa3e1 - Browse repository at this point
Copy the full SHA cefa3e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 319ee49 - Browse repository at this point
Copy the full SHA 319ee49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a74d83 - Browse repository at this point
Copy the full SHA 1a74d83View commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb4580c - Browse repository at this point
Copy the full SHA cb4580cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a279738 - Browse repository at this point
Copy the full SHA a279738View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b65c1a - Browse repository at this point
Copy the full SHA 7b65c1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 602c01e - Browse repository at this point
Copy the full SHA 602c01eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b28736c - Browse repository at this point
Copy the full SHA b28736cView commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ad03ac - Browse repository at this point
Copy the full SHA 1ad03acView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac0a1da - Browse repository at this point
Copy the full SHA ac0a1daView commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 33e7ae8 - Browse repository at this point
Copy the full SHA 33e7ae8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcdb2cb - Browse repository at this point
Copy the full SHA dcdb2cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07f64a0 - Browse repository at this point
Copy the full SHA 07f64a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b62b238 - Browse repository at this point
Copy the full SHA b62b238View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 85e90bb - Browse repository at this point
Copy the full SHA 85e90bbView commit details -
As presented in the issue, we might end up in situation when parallel-processing and accepting two neutral+ trade offers will result in unwanted inventory state, because while they're both neutral+ and therefore OK to accept standalone, the combination of them both causes active badge progress degradation. Considering the requirements we have, e.g. still processing trades in parallel, being performant, low on resources and with limited Steam servers overhead, the solution that I came up with in regards to this issue is quite simple: - After we determine the trade to be neutral+, but before we tell the parse trade routine to accept it, we check if shared with other parallel processes set of handled sets contains any sets that we're currently processing. - If no, we update that set to include everything we're dealing with, and tell the caller to accept this trade. - If yes, we tell the caller to retry this trade after (other) accepted trades are confirmed and handled as usual. This solves some issues and creates some optimistic assumptions: - First of all, it solves the original issue, since if trade A and B both touch set S, then only one of them will be accepted. It's not deterministic which one (the one that gets to the check first), and not important anyway. - We do not "lock" the sets before we determine that trade is neutral+, because otherwise unrelated users could spam us with non-neutral+ trades in order to lock the bot in infinite retry. This way they can't, as if the trade is determined to not be neutral+ then it never checks for concurrent processing. - We are optimistic about resources usage. This routine could be made much more complicated to be more synchronous in order to avoid unnecessary calls to inventory and matching, however, that'd slow down the whole process only because the next call MAYBE will be determined as unneeded. Due to that, ASF is optimistic that trades will (usually) be unrelated, and can be processed in parallel, and if the conflict happens then simply we end up in a situation where we did some extra work for no reason, which is better than waiting with the work till all previous trades are processed. - As soon as the conditions are met, the conflicting trades are retried to check if the conditions allow to accept them. If yes, they'll be accepted almost immediately after previous ones, if not, they'll be rejected as non-neutral+ anymore. This way the additional code does not hurt the performance, parallel processing or anything else in usually expected optimistic scenarios, while adding some additional overhead in pessimistic ones, which is justified considering we don't want to degrade the badge progress.
Configuration menu - View commit details
-
Copy full SHA for 1dff9a4 - Browse repository at this point
Copy the full SHA 1dff9a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 440e439 - Browse repository at this point
Copy the full SHA 440e439View commit details -
Configuration menu - View commit details
-
Copy full SHA for dca2e6f - Browse repository at this point
Copy the full SHA dca2e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c0e14f - Browse repository at this point
Copy the full SHA 2c0e14fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2f83b0 - Browse repository at this point
Copy the full SHA f2f83b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d05c6b9 - Browse repository at this point
Copy the full SHA d05c6b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 708c523 - Browse repository at this point
Copy the full SHA 708c523View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 26765f3 - Browse repository at this point
Copy the full SHA 26765f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d21795 - Browse repository at this point
Copy the full SHA 7d21795View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e30183 - Browse repository at this point
Copy the full SHA 8e30183View commit details -
Configuration menu - View commit details
-
Copy full SHA for a701e14 - Browse repository at this point
Copy the full SHA a701e14View commit details
Commits on Sep 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d79af97 - Browse repository at this point
Copy the full SHA d79af97View commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3f605d5 - Browse repository at this point
Copy the full SHA 3f605d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cc684f - Browse repository at this point
Copy the full SHA 5cc684fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40dc70e - Browse repository at this point
Copy the full SHA 40dc70eView commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ea110d5 - Browse repository at this point
Copy the full SHA ea110d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c79faf6 - Browse repository at this point
Copy the full SHA c79faf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0982943 - Browse repository at this point
Copy the full SHA 0982943View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc363c2 - Browse repository at this point
Copy the full SHA cc363c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b91674 - Browse repository at this point
Copy the full SHA 1b91674View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 44ed1b1 - Browse repository at this point
Copy the full SHA 44ed1b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83aa57a - Browse repository at this point
Copy the full SHA 83aa57aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2555623 - Browse repository at this point
Copy the full SHA 2555623View commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b5f916d - Browse repository at this point
Copy the full SHA b5f916dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aed6784 - Browse repository at this point
Copy the full SHA aed6784View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9325959 - Browse repository at this point
Copy the full SHA 9325959View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ee23400 - Browse repository at this point
Copy the full SHA ee23400View commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2478dd6 - Browse repository at this point
Copy the full SHA 2478dd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 246429f - Browse repository at this point
Copy the full SHA 246429fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 088161e - Browse repository at this point
Copy the full SHA 088161eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fc4ac8 - Browse repository at this point
Copy the full SHA 1fc4ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c21c22 - Browse repository at this point
Copy the full SHA 0c21c22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f4d5df - Browse repository at this point
Copy the full SHA 9f4d5dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 168dc5c - Browse repository at this point
Copy the full SHA 168dc5cView commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for da04f6b - Browse repository at this point
Copy the full SHA da04f6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37afe19 - Browse repository at this point
Copy the full SHA 37afe19View commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e44d1ac - Browse repository at this point
Copy the full SHA e44d1acView commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c6261af - Browse repository at this point
Copy the full SHA c6261afView commit details -
Configuration menu - View commit details
-
Copy full SHA for b66dd2c - Browse repository at this point
Copy the full SHA b66dd2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7f2556 - Browse repository at this point
Copy the full SHA a7f2556View commit details -
Handle exceptions in ArchiCacheable
While our code does not throw them, this is public helper and we don't need to enforce from other callers exceptions-less flow. We can use it for a failure.
Configuration menu - View commit details
-
Copy full SHA for ba11952 - Browse repository at this point
Copy the full SHA ba11952View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2abbf0 - Browse repository at this point
Copy the full SHA c2abbf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55d49f8 - Browse repository at this point
Copy the full SHA 55d49f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7a6cc5 - Browse repository at this point
Copy the full SHA b7a6cc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5df9e0 - Browse repository at this point
Copy the full SHA d5df9e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 889795a - Browse repository at this point
Copy the full SHA 889795aView commit details -
chore(deps): update wiki digest to 66d2709 (#3295)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f984a91 - Browse repository at this point
Copy the full SHA f984a91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 641cf5a - Browse repository at this point
Copy the full SHA 641cf5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42e07c2 - Browse repository at this point
Copy the full SHA 42e07c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae0704e - Browse repository at this point
Copy the full SHA ae0704eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e34619 - Browse repository at this point
Copy the full SHA 1e34619View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39f7f0a - Browse repository at this point
Copy the full SHA 39f7f0aView commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a644721 - Browse repository at this point
Copy the full SHA a644721View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c72812 - Browse repository at this point
Copy the full SHA 5c72812View commit details
Commits on Oct 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d72eb0b - Browse repository at this point
Copy the full SHA d72eb0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ae45f - Browse repository at this point
Copy the full SHA c6ae45fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61aa656 - Browse repository at this point
Copy the full SHA 61aa656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90a27b2 - Browse repository at this point
Copy the full SHA 90a27b2View commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6bb3d4b - Browse repository at this point
Copy the full SHA 6bb3d4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0614133 - Browse repository at this point
Copy the full SHA 0614133View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97ecba0 - Browse repository at this point
Copy the full SHA 97ecba0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7650ab - Browse repository at this point
Copy the full SHA e7650abView commit details
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8cabec1 - Browse repository at this point
Copy the full SHA 8cabec1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cc1689 - Browse repository at this point
Copy the full SHA 4cc1689View commit details -
Configuration menu - View commit details
-
Copy full SHA for d074f47 - Browse repository at this point
Copy the full SHA d074f47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92456aa - Browse repository at this point
Copy the full SHA 92456aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d609a68 - Browse repository at this point
Copy the full SHA d609a68View commit details -
Close log endpoints upon graceful shutdown request
Previously we've kept websocket connection open for as long as caller requested it. During graceful shutdown, ASP.NET normally waits for all pending requests to finish, while no longer accepting new ones - this is a very good approach. In our case however, since we didn't do anything with that event before, the graceful shutdown was timing out after 30 seconds before eventually forcefully killing any still-ongoing requests, websocket connection in our case. Hook into application lifetime in order to be notified when the graceful shutdown happens. This way we can create linked cancellation token for request abort and graceful shutdown and close the websocket connection when any of those two happens.
Configuration menu - View commit details
-
Copy full SHA for f534997 - Browse repository at this point
Copy the full SHA f534997View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9590afa - Browse repository at this point
Copy the full SHA 9590afaView commit details
Commits on Oct 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8ed2701 - Browse repository at this point
Copy the full SHA 8ed2701View commit details -
Configuration menu - View commit details
-
Copy full SHA for 731fbca - Browse repository at this point
Copy the full SHA 731fbcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for de9900a - Browse repository at this point
Copy the full SHA de9900aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a115f1 - Browse repository at this point
Copy the full SHA 5a115f1View commit details
Commits on Oct 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9b40ab3 - Browse repository at this point
Copy the full SHA 9b40ab3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33c9aed - Browse repository at this point
Copy the full SHA 33c9aedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 500a148 - Browse repository at this point
Copy the full SHA 500a148View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7524af - Browse repository at this point
Copy the full SHA c7524afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53066b1 - Browse repository at this point
Copy the full SHA 53066b1View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3cff631 - Browse repository at this point
Copy the full SHA 3cff631View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90c2986 - Browse repository at this point
Copy the full SHA 90c2986View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94ed859 - Browse repository at this point
Copy the full SHA 94ed859View commit details -
Configuration menu - View commit details
-
Copy full SHA for a173c84 - Browse repository at this point
Copy the full SHA a173c84View commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d2f4fd - Browse repository at this point
Copy the full SHA 9d2f4fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3d579a - Browse repository at this point
Copy the full SHA c3d579aView commit details -
chore(deps): update dependency microsoft.codeanalysis.resxsourcegener…
…ator to 3.11.0-beta1.24454.1
Configuration menu - View commit details
-
Copy full SHA for e45b09b - Browse repository at this point
Copy the full SHA e45b09bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57489bc - Browse repository at this point
Copy the full SHA 57489bcView commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 79b81ac - Browse repository at this point
Copy the full SHA 79b81acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87d28ae - Browse repository at this point
Copy the full SHA 87d28aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32c107a - Browse repository at this point
Copy the full SHA 32c107aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74b832e - Browse repository at this point
Copy the full SHA 74b832eView commit details
Commits on Oct 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec28ae5 - Browse repository at this point
Copy the full SHA ec28ae5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6cb7ce - Browse repository at this point
Copy the full SHA e6cb7ceView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1a9f2a2 - Browse repository at this point
Copy the full SHA 1a9f2a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a84b9ca - Browse repository at this point
Copy the full SHA a84b9caView commit details
Commits on Oct 12, 2024
-
Implement extra bullet-proofing and synchronization over connect/disc…
…onnect logic Address @ezhevita findings in regards to race conditions: - NRE in this lambda function: https://github.com/JustArchiNET/ArchiSteamFarm/blob/1a9f2a23c45f35a969c4c9ec77a4eaa28a7136a3/ArchiSteamFarm/Steam/Bot.cs#L1962 - NRE in the ArchiSteamFarm.Steam.Bot.StopHandlingCallbacks (probably race condition?) In general, both are caused by race conditions which can happen if user attempts to start/stop bot while critical section of handling callbacks loop is going. The code is overly complex unfortunately, so debugging it/guarantee of safety is problematic. This commit therefore attempts to fix the underlying issue by synchronizing the code that starts/stops the underlying callbacks handling loop. While the loop itself is already thread-safe, the code that starts/stops it was not before. Now Start() as well as Stop() can not occur concurrently. On top of that, the only other place which has potential to stop the loop - final disconnect, is also guarded with additional condition that it can fire only if we're NOT set to KeepRunning at the time of calling, which should fix the situation where late disconnected callback could potentially stop already triggered new loop. As usual in such complex situations, time will tell if this fixes all the issues we have.
Configuration menu - View commit details
-
Copy full SHA for b0254ae - Browse repository at this point
Copy the full SHA b0254aeView commit details -
Don't force reconnect if we're somehow already connected during Start()
Configuration menu - View commit details
-
Copy full SHA for b0e3694 - Browse repository at this point
Copy the full SHA b0e3694View commit details -
Configuration menu - View commit details
-
Copy full SHA for f427b89 - Browse repository at this point
Copy the full SHA f427b89View commit details -
Configuration menu - View commit details
-
Copy full SHA for f32fafd - Browse repository at this point
Copy the full SHA f32fafdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f48caa0 - Browse repository at this point
Copy the full SHA f48caa0View commit details
Commits on Oct 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3e4c7ac - Browse repository at this point
Copy the full SHA 3e4c7acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d383dc - Browse repository at this point
Copy the full SHA 5d383dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for dae03af - Browse repository at this point
Copy the full SHA dae03afView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2b8897 - Browse repository at this point
Copy the full SHA f2b8897View commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fc64511 - Browse repository at this point
Copy the full SHA fc64511View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a9750a - Browse repository at this point
Copy the full SHA 5a9750aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d166e19 - Browse repository at this point
Copy the full SHA d166e19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2475c04 - Browse repository at this point
Copy the full SHA 2475c04View commit details
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 50fc619 - Browse repository at this point
Copy the full SHA 50fc619View commit details -
Configuration menu - View commit details
-
Copy full SHA for a28c431 - Browse repository at this point
Copy the full SHA a28c431View commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 90756bd - Browse repository at this point
Copy the full SHA 90756bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for def6b67 - Browse repository at this point
Copy the full SHA def6b67View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3b0d0e0 - Browse repository at this point
Copy the full SHA 3b0d0e0View commit details