This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
[WIP] Refactor aggregation script + new features #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thekaveman can you take a look at the new aggregation script? It'd be best to just look at the current script instead of trying to make sense of the diff. Also, is there anything else I should add to the to do list? |
|
I will take a look! Thanks dude. |
allejo
force-pushed
the
feature/aggregate-script-46
branch
from
1177e88 to
546b6dd
Compare
- Add ignore rules for common compressions used for backed up data during development - Ignore Python's cache - Ignore pyenv definition - Ignore Visual Studio Code's project settings
- Rewrite and optimize the entire script - Add basic unit tests for the core functions of the script that handle the actual data manipulation
The Makefile's 'fetch' command should respective the REALTIME variable to replicate the prod env
allejo
force-pushed
the
feature/aggregate-script-46
branch
from
2eb7dc8 to
60d487d
Compare
Relying on the data in the filesystem is only reliable when working with a clean slate. However, deleting websites will leave old data behind, so instead of checking the filesystem, use Jekyll generated files for their actual purpose: being the authoritative source of sites & reports. Fixes #57
thekaveman
reviewed
Oct 27, 2017
| except IOError: | ||
| pass | ||
| # Reports that will not be aggregated by this script | ||
| ignored_reports = [] |
There was a problem hiding this comment.
I know we had this in the previous version - we haven't used it though, right? And it isn't being populated from any environment variables or elsewhere. Do we need this right now?
If not, we can also cleanup below L176-177
| } | ||
|
|
||
| for k in aggregationDefinitions: | ||
| v = aggregationDefinitions[k] |
There was a problem hiding this comment.
for k, v in aggregationDefinitions.items():
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
To Do: