Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10349: Restructuring code #1623

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

UHF-10349: Restructuring code #1623

wants to merge 5 commits into from

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Dec 30, 2024

UHF-10349

Move conversion functions from GrantsHandler into their own helper class.

What was done

  • Added new class ConversionHelpers
  • Moved conversion functions from GrantsHandler to ConversionHelpers
  • Fixed all references to moved functions

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10349
    • make fresh
  • Run make drush-cr

How to test

  • Try to produce any calls to moved GrantsHandler functions using grep or similar (you shouldn't find any)
  • Try filling a couple of applications and sending them
  • If you encounter any errors, check docker compose logs app -f|grep error to see what is up
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • [] This PR has been visually reviewed by a designer (Name of the designer)

Automatic- / Regression tests

  • This PR makes no changes that effects any tests. (This will be caught in automatic testing later on, but please, please run regression tests always on PR before asking for a review)
  • This PR passes regression tests. (make test-pw)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
56.8% Duplication on New Code (required ≤ 30%)

See analysis details on SonarQube Cloud

@jeremysteerio jeremysteerio marked this pull request as draft December 30, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant