-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Upgrade @playwright/test from 1.41.2 to 1.48.0 #1544
Merged
jiisuominen
merged 2 commits into
develop
from
snyk-upgrade-b785815b434b86e46b4901cb202437dd
Nov 6, 2024
Merged
[Snyk] Upgrade @playwright/test from 1.41.2 to 1.48.0 #1544
jiisuominen
merged 2 commits into
develop
from
snyk-upgrade-b785815b434b86e46b4901cb202437dd
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk has created this PR to upgrade @playwright/test from 1.41.2 to 1.48.0. See this package in npm: @playwright/test See this project in Snyk: https://app.snyk.io/org/city-of-helsinki/project/aed93529-486e-499e-9b12-5815057dc0ec?utm_source=github&utm_medium=referral&page=upgrade-pr
Quality Gate passedIssues Measures |
jiisuominen
restored the
snyk-upgrade-b785815b434b86e46b4901cb202437dd
branch
November 6, 2024 06:37
hyrsky
added a commit
that referenced
this pull request
Nov 26, 2024
* UHF-10354: new cron entrypoint (#1506) * UHF-10354: Remove base.sh * UHF-10354: Remove migrate-hearings.sh * UHF-10343: Updating the liikunta_suunnistuskartta_avustus forms texts (#1513) * UHF-10343: Update liikunta_suunnistuskartta_avustus forms texts to new version * UHF-10343: Fix issue with application search where the search button and the clear the search button have no spacing in between * UHF-10343: Fix issue with unneccessary wrapper around the application search form styles * UHF-10248: Run tests against automatic updates (#1516) * UHF-10131: sentry (#1515) * UHF-10131: Repurpose grants_logger module for sentry logging * UHF-10131: Fix typo * UHF-10131: Code deduplication * UHF-10131: Capture exceptions * UHF-10131: Remove comment * feat: UHF-XXXX: Fix failing tests by fixing dependency-related errors. (#1517) * Refactor events to custom module to get installation to succeed * Make some services use lazyloading with events service. * Add update hook & make sure drush deploy is run 1st. * PHPCS * Try to clear caches after importing DB to no avail. * fix: Disable pubsub (#1518) * must be completely commented out (#1519) * UHF-10276: Replace old dialog.js implementation from forms (#1511) * UHF-10276: Replace the dialog.js functionality with custom dialog * UHF-10276: Fix translations, style the close button on the dialog * UHF-10276: Add focus trap for the dialog * UHF-10276: Refactor dialog and survey styles together * UHF-10276: Add comment about survey similarities * UHF-10276: Refactor dialog to a separate file so it can be used by other grants modules, refactored dialog.js away from grants_profile, add translations and remove old dialog.js --------- Co-authored-by: Janne Suominen <janne.suominen@siili.com> * Removed article permissions (#1522) * Automatic update (#1520) * Update configuration * Revert unwanted changes from configuration * Revert unwanted changes from configuration * Update .gitignore * Removed article permissions --------- Co-authored-by: Tero Elonen <tero.elonen@druid.fi> Co-authored-by: Janne Suominen <janne.suominen@siili.com> Co-authored-by: tuutti <tuutti@iki.fi> * UHF-10276: Fix translations on webform.form.unsaved.js (#1525) * UHF-10276: Replace the dialog.js functionality with custom dialog * UHF-10276: Fix translations, style the close button on the dialog * UHF-10276: Add focus trap for the dialog * UHF-10276: Refactor dialog and survey styles together * UHF-10276: Add comment about survey similarities * UHF-10276: Refactor dialog to a separate file so it can be used by other grants modules, refactored dialog.js away from grants_profile, add translations and remove old dialog.js * UHF-10276: Manually trigger translations for the webform.form.unsaved javascript file * Update configuration (#1523) * fix: [Snyk] Upgrade @playwright/test from 1.41.2 to 1.48.0 (#1544) * fix: upgrade @playwright/test from 1.41.2 to 1.48.0 Snyk has created this PR to upgrade @playwright/test from 1.41.2 to 1.48.0. See this package in npm: @playwright/test See this project in Snyk: https://app.snyk.io/org/city-of-helsinki/project/aed93529-486e-499e-9b12-5815057dc0ec?utm_source=github&utm_medium=referral&page=upgrade-pr * Update e2e docker image --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io> * Version bump * Update core to 10.3.10 --------- Co-authored-by: Santeri Hurnanen <santeri.hurnanen@fame.fi> Co-authored-by: Tero Elonen <2276077+teroelonen@users.noreply.github.com> Co-authored-by: tuutti <tuutti@iki.fi> Co-authored-by: rpnykanen <48206082+rpnykanen@users.noreply.github.com> Co-authored-by: hel-platta-automation <95360595+hel-platta-automation@users.noreply.github.com> Co-authored-by: Tero Elonen <tero.elonen@druid.fi> Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to upgrade @playwright/test from 1.41.2 to 1.48.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 418 versions ahead of your current version.
The recommended version was released on a month ago.
Release notes
Package name: @playwright/test
WebSocket routing
New methods page.routeWebSocket() and browserContext.routeWebSocket() allow to intercept, modify and mock WebSocket connections initiated in the page. Below is a simple example that mocks WebSocket communication by responding to a
"request"
with a"response"
.See WebSocketRoute for more details.
UI updates
Miscellaneous
form
and similar ones now accept FormData.location
to pass custom step location.Browser Versions
This version was also tested against the following stable channels:
Highlights
#32699 [REGRESSION]: fix(codegen): use content_frame property in python/.NET
#32706 [REGRESSION]: page.pause() does not pause test timeout after 1.47
#32661 - fix(trace-viewer): time delta between local and remote actions
Browser Versions
This version was also tested against the following stable channels:
Highlights
#32480 - [REGRESSION]: tsconfig.json's compilerOptions.paths no longer working in 1.47
#32552 - [REGRESSION]: broken UI in Trace Viewer while showing network response body
Browser Versions
This version was also tested against the following stable channels:
Network Tab improvements
The Network tab in the UI mode and trace viewer has several nice improvements:
Credit to @ kubajanik for these wonderful improvements!
--tsconfig
CLI optionBy default, Playwright will look up the closest tsconfig for each imported file using a heuristic. You can now specify a single tsconfig file in the command line, and Playwright will use it for all imported files, not only test files:
APIRequestContext now accepts
URLSearchParams
andstring
as query parametersYou can now pass
URLSearchParams
andstring
as query parameters to APIRequestContext:Miscellaneous
mcr.microsoft.com/playwright:v1.47.0
now serves a Playwright image based on Ubuntu 24.04 Noble.To use the 22.04 jammy-based image, please use
mcr.microsoft.com/playwright:v1.47.0-jammy
instead.:latest
/:focal
/:jammy
tag for Playwright Docker images is no longer being published. Pin to a specific version for better stability and reproducibility.behavior
in page.removeAllListeners(), browser.removeAllListeners() and browserContext.removeAllListeners() to wait for ongoing listeners to complete.cert
andkey
as buffers instead of file paths.text/html
content type can now be opened in a new tab in the HTML report. This is useful for including third-party reports or other HTML content in the Playwright test report and distributing it to your team.noWaitAfter
in locator.selectOption() was deprecated.macos-13
. We recommend upgrading GitHub Actions tomacos-14
.Browser Versions
This version was also tested against the following stable channels:
Highlights
#32004 - [REGRESSION]: Client Certificates don't work with Microsoft IIS
#32004 - [REGRESSION]: Websites stall on TLS handshake errors when using Client Certificates
#32146 - [BUG]: Credential scanners warn about internal socks-proxy TLS certificates
#32056 - [REGRESSION]: 1.46.0 (TypeScript) - custom fixtures extend no longer chainable
#32070 - [Bug]: --only-changed flag and project dependencies
#32188 - [Bug]: --only-changed with shallow clone throws "unknown revision" error
Browser Versions
This version was also tested against the following stable channels:
TLS Client Certificates
Playwright now allows to supply client-side certificates, so that server can verify them, as specified by TLS Client Authentication.
When client certificates are specified, all browser traffic is routed through a proxy that establishes the secure TLS connection, provides client certificates to the server and validates server certificates.
The following snippet sets up a client certificate for
https://example.com
:export default defineConfig({
// ...
use: {
clientCertificates: [{
origin: 'https://example.com',
certPath: './cert.pem',
keyPath: './key.pem',
passphrase: 'mysecretpassword',
}],
},
// ...
});
You can also provide client certificates to a particular test project or as a parameter of browser.newContext() and apiRequest.newContext().
--only-changed
cli optionNew CLI option
--only-changed
allows to only run test files that have been changed since the last git commit or from a specific git "ref".npx playwright test --only-changed
# Only run test files changed relative to the "main" branch
npx playwright test --only-changed=main
Component Testing: New
router
fixtureThis release introduces an experimental
router
fixture to intercept and handle network requests in component testing.There are two ways to use the router fixture:
router.route(url, handler)
that behaves similarly to page.route().router.use(handlers)
and pass MSW library request handlers to it.Here is an example of reusing your existing MSW handlers in the test.
test.beforeEach(async ({ router }) => {
// install common handlers before each test
await router.use(...handlers);
});
test('example test', async ({ mount }) => {
// test as usual, your handlers are active
// ...
});
This fixture is only available in component tests.
UI Mode / Trace Viewer Updates
baseURL
.Miscellaneous
maxRetries
option in apiRequestContext.fetch() which retries on theECONNRESET
network error.Possibly breaking change
Fixture values that are array of objects, when specified in the
test.use()
block, may require being wrapped into a fixture tuple. This is best seen on the example:// Define an option fixture that has an "array of objects" value
type User = { name: string, password: string };
const test = base.extend<{ users: User[] }>({
users: [ [], { option: true } ],
});
// Specify option value in the test.use block.
test.use({
// WRONG: this syntax may not work for you
users: [
{ name: 'John Doe', password: 'secret' },
{ name: 'John Smith', password: 's3cr3t' },
],
// CORRECT: this syntax will work. Note extra [] around the value, and the "scope" property.
users: [[
{ name: 'John Doe', password: 'secret' },
{ name: 'John Smith', password: 's3cr3t' },
], { scope: 'test' }],
});
test('example test', async () => {
// ...
});
Browser Versions
This version was also tested against the following stable channels:
Highlights
#31764 - [Bug]: some actions do not appear in the trace file
microsoft/playwright-java#1617 - [Bug]: Traceviewer not reporting all actions
Browser Versions
This version was also tested against the following stable channels:
Highlights
#31613 - [REGRESSION]: Trace is not showing any screenshots nor test name
#31601 - [REGRESSION]: missing trace for 2nd browser
#31541 - [REGRESSION]: Failing tests have a trace with no images and with steps missing
Browser Versions
This version was also tested against the following stable channels: