Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10936 #71

Merged
merged 2 commits into from
Dec 16, 2024
Merged

UHF-10936 #71

merged 2 commits into from
Dec 16, 2024

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Dec 11, 2024

UHF-10936

What was done

  • Fixed missing position relative that would cause the Koro to go to wrong place
  • fixed item margins
  • Changed paragraph to use common margins

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10936
    • make fresh
  • Run make drush-cr

How to test

  • Add for example to the front page a paragraph called content liftup, add other paragraphs before and after it
  • Make sure the koro is now in the correct place (in the bottom of the paragraph)
  • Make sure there is space before and after the paragraph compared to other paragraphs
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@juho-lehmonen juho-lehmonen self-requested a review December 11, 2024 17:48
@annadruid annadruid merged commit c122afc into dev Dec 16, 2024
3 checks passed
@annadruid annadruid deleted the UHF-10936 branch December 16, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants