-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Implementation Making Queue Size Configurable by Workers #53
Open
gxuu
wants to merge
6
commits into
Citi:main
Choose a base branch
from
gxuu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More detail in the discussion of issue #51. This is not ready to merge and I plan to make improvement after receiving feedback. |
1597463007
reviewed
Jan 31, 2025
As instructed, this commit does the following things. - Use orignal name instead of creating new APIs. Note, this means breaking change to existing code. The original per_worker_queue_size is removed. - Change related functions in entry_point/ directory. - Modify test to cooperate with new function signatures. - Rewrite the balance algorithm.
Sync with the upstream
UPD: This commit refactors the worker queue handling and balance algorithm. The changes include:
Note on design:
I would like to receive one more round of feedback before cleaning up the mess. That said, I think all the changes that needs to be done are done. gxu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rolled a basic solution according to the requirements outlined in issue #51. I welcome any comments and advice to further improve the program.