Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate.py always creates model bundles with requirements for current YDK version #844

Closed
ygorelik opened this issue Dec 10, 2018 · 1 comment
Closed

generate.py always creates model bundles with requirements for current YDK version #844

ygorelik opened this issue Dec 10, 2018 · 1 comment
Assignees
@ygorelik
Labels
bug bundle
Milestone
0.8.1

Comments

@ygorelik
Copy link
Collaborator

Expected Behavior

The generate.py script should follow YDK core release dependency, which is specified in the bundle profile.

Current Behavior

The generate.py script ignores YDK core release dependency, which is specified in the bundle profile, and create dependency to current release of YDK.

Steps to Reproduce

In YDK-0.8.0 generate bundle from profile profiles/bundles/cisco-nx-os-9_2_2.json, which specifies in dependency section: "core_version": "0.7.3"

Examine generated file ydk-gen/gen-api/python/cisco_nx_os-bundlesetup.py.
Note:
INSTALL_REQUIREMENTS = ['ydk>=0.8.0']

Expected:
INSTALL_REQUIREMENTS = ['ydk>=0.7.3']

System Information

YDK-0.8.0
@ghost ghost added this to the 0.8.1 milestone Jan 25, 2019
@ghost ghost added the bundle label Jan 25, 2019
@ygorelik ygorelik added the bug label Jan 30, 2019
@ygorelik ygorelik self-assigned this Jan 30, 2019
@ygorelik
Copy link
Collaborator Author

Resolved the bug in YDK-0.8.1.

@ygorelik ygorelik mentioned this issue Feb 1, 2019
Merged
ygorelik added a commit that referenced this issue Feb 1, 2019
@ygorelik
Merge pull request #868 from ygorelik/gnmi
529a7a8 
Addressed Codacy issues and #853, #864, #844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ygorelik ygorelik

Labels
bug bundle
Projects
None yet
Milestone
0.8.1
Development

No branches or pull requests
1 participant
@ygorelik