Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mso_schema_site_template_contract_service_graph resource and data-source #248

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

sajagana
Copy link
Collaborator

@sajagana sajagana commented Nov 3, 2023

Note:

Added site_template_contract_service_graph resource and data-source to manage the Site template contract service graph

anvitha-jain
anvitha-jain previously approved these changes Nov 3, 2023
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana self-assigned this Nov 6, 2023
mso/provider.go Outdated Show resolved Hide resolved
mso/provider.go Outdated Show resolved Hide resolved
mso/resource_mso_site_template_contract_service_graph.go Outdated Show resolved Hide resolved
akinross
akinross previously approved these changes Nov 6, 2023
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana changed the title Added site_template_contract_service_graph resource and data-source Added mso_site_contract_service_graph resource and data-source Nov 6, 2023
@sajagana sajagana changed the title Added mso_site_contract_service_graph resource and data-source Added mso_schema_site_template_contract_service_graph resource and data-source Nov 6, 2023
samiib
samiib previously approved these changes Nov 6, 2023
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…d datasource to manage the Site template contract service graph
… schema_site_template_contract_service_graph and changed the function names
@sajagana sajagana dismissed stale reviews from samiib and akinross via ee2a0f1 November 7, 2023 03:06
@sajagana sajagana force-pushed the 190_site_template_contract_sg branch from b04598f to ee2a0f1 Compare November 7, 2023 03:06
@shrsr shrsr requested a review from lhercot November 7, 2023 19:48
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 2c45c4c into CiscoDevNet:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants