Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

185 missing site external epg docs #204

Merged
merged 9 commits into from
Jun 16, 2023
Merged

185 missing site external epg docs #204

merged 9 commits into from
Jun 16, 2023

Conversation

akinross
Copy link
Collaborator

fixes #185

shrsr
shrsr requested changes May 15, 2023
View reviewed changes
mso/datasource_mso_schema_site_external_epg.go Outdated Show resolved Hide resolved
mso/datasource_mso_schema_site_external_epg.go Outdated Show resolved Hide resolved
@akinross akinross requested a review from shrsr May 15, 2023 14:19
@anvitha-jain anvitha-jain self-requested a review May 16, 2023 18:25
anvitha-jain
anvitha-jain previously approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot requested review from sajagana and shrsr May 19, 2023 14:45
shrsr
shrsr previously approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross dismissed stale reviews from shrsr and anvitha-jain via 580bf11 May 24, 2023 07:41
@akinross akinross requested a review from sajagana May 24, 2023 07:42
@akinross
[bugfix] ensure correct information is retrieved with template/site c…
4dce3ce 
…ombination for mso_schema_site_external_epg datasource
@akinross akinross force-pushed the 185_missing_site_external_epg_docs branch from b8825df to fd52944 Compare May 24, 2023 14:10
@akinross akinross requested a review from shrsr May 24, 2023 14:11
shrsr
shrsr approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhercot lhercot merged commit 51482c5 into CiscoDevNet:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrsr shrsr shrsr approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@sajagana sajagana sajagana approved these changes

@lhercot lhercot Awaiting requested review from lhercot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation of mso_schema_site_external_epg resource and data source is missing
5 participants
@akinross @lhercot @shrsr @anvitha-jain @sajagana