Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDF decryption issue for some empty password files #1079

Merged

Commits on Nov 3, 2023

  1. Fix PDF decryption issue for some empty password files

    Some PDF's with an empty password can't be decrypted. Investigation
    found that the problem is a strlen check to prevent an overflow rather
    than passing down the actual length of the allocated field.
    
    Specifically, the UE buffer may have NULL values in it, so a strlen
    check will claim the field is shorter than it is and then later checks
    fail because the length is the wrong size.
    
    While at it, I improved code comments on the function reading dictionary
    key-value strings and switched a flag use a bool rather than an int.
    micahsnyder committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    814325a View commit details
    Browse the repository at this point in the history