Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix graphs interface for weighted graphs #6

Merged
merged 1 commit into from
Nov 15, 2021
Merged

fix graphs interface for weighted graphs #6

merged 1 commit into from
Nov 15, 2021

Conversation

vlandau
Copy link
Member

@vlandau vlandau commented Nov 15, 2021

Prior to this merge, Graphs methods weren't working properly for WeightedRasterGraph and WeightedRasterDiGraph types when installing SpatialGraphs to a different machine. I'm not sure why.... This PR updates the graphs methods extensions to explicitly call methods from SimpleWeightedGraphs for the aforementioned SpatialGraphs types.

@vlandau vlandau marked this pull request as draft November 15, 2021 17:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #6 (2239a83) into main (8b96328) will decrease coverage by 4.79%.
The diff coverage is 78.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   97.68%   92.89%   -4.80%     
==========================================
  Files           5        5              
  Lines         173      211      +38     
==========================================
+ Hits          169      196      +27     
- Misses          4       15      +11     
Impacted Files Coverage Δ
src/graph_interface.jl 80.64% <78.43%> (-15.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b96328...2239a83. Read the comment docs.

@vlandau vlandau marked this pull request as ready for review November 15, 2021 17:57
@vlandau vlandau merged commit a4fd38a into main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants