Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explode yaml before merge #94

Merged

Conversation

bentastic27
Copy link
Contributor

Fixes:
#88

My change will resolve yaml aliases (exploding them?) before merging the yaml together. This solves the mentioned issue as well as another I faced where some aliases were rendered after the jobs/workflows they are used by in the resulting config file which causes errors.

@pc-bob
Copy link

pc-bob commented Jul 15, 2024

Would be awesome to get this PR merged.

@kelvintaywl
Copy link

Thank you @bentastic27 and @pc-bob

I wanted to iterate that this looks to be an issue with the ireduce operator from yq.
Ref: mikefarah/yq#1738 where the user also solved their issue via using the explode operator.

Nevertheless, it is likely that CircleCI users use aliases and anchors in their config.
So, using the path-filtering@1.0.0 orb can see the error explained by @bentastic27 and in #88 as well.

As a support engineer with CircleCI, I encountered this issue for another customer.
Hence, I am reaching out to our engineers to see if we can have this merged 🙏

@bjohnso5 bjohnso5 merged commit b493ba3 into CircleCI-Public:main Jul 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants