Fix values being unquoted #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h42zhu
reviewed
Jul 11, 2023
h42zhu
approved these changes
Jul 11, 2023
stig
reviewed
Jul 11, 2023
Fernando-Abreu
force-pushed
the
fix-config-quotes-removal
branch
from
7742e99 to
95d3c5e
Compare
stig
reviewed
Jul 11, 2023
src/scripts/generate-config.sh
Outdated
Comment on lines
58
to
59
| awk '{$1=$1};1' \ | ||
| | awk 'NF {printf "\"%s\" ", $0}' \ |
There was a problem hiding this comment.
These two can be combined, which removes the need for the "hack" of adding the 1 as the action.
Suggested change
| awk '{$1=$1};1' \ | |
| | awk 'NF {printf "\"%s\" ", $0}' \ | |
| awk 'NF {$1=$1; printf "\"%s\" ", $0}' \ |
Using Cue library it remove quotation from config values. This has caused issues for a customer which had a hex string being transformed to a float number
Fernando-Abreu
force-pushed
the
fix-config-quotes-removal
branch
from
95d3c5e to
bd4c726
Compare
stig
approved these changes
Jul 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
Cue library removes quotations from config values. This has caused issues for a customer with a hex string being transformed into a float number.
YQ library doesn't alter quotations by default.